Skip to content

Commit

Permalink
Create Ruby on Rails section of code review
Browse files Browse the repository at this point in the history
Extracted from old thoughtbot development handbook.
  • Loading branch information
Dan Croak committed Mar 14, 2013
1 parent 2ebc92a commit 1254b5f
Showing 1 changed file with 15 additions and 0 deletions.
15 changes: 15 additions & 0 deletions code-review/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,18 @@ An example response to style comments:

If you disagree with a guideline, open an issue on the guides repo rather than
debating it within the code review. In the meantime, apply the guideline.

Ruby on Rails review
--------------------

* Review data integrity closely, such as migrations that make irreversible
changes to the data, and whether there is a related todo to make a database
backup during the staging and production deploys.
* Review SQL queries for potential SQL injection.
* Review whether dependency upgrades include a reason in the commit message,
such as a link to the dependency's `ChangeLog` or `NEWS` file.
* Review whether new database indexes are necessary if new columns or SQL
queries were added.
* Review whether new scheduler (`cron`) tasks have been added and whether there
is a related todo in the project management system to add it during the
staging and production deploys.

0 comments on commit 1254b5f

Please sign in to comment.