Skip to content
Browse files

Create Ruby on Rails section of code review

Extracted from old thoughtbot development handbook.
  • Loading branch information...
1 parent 2ebc92a commit 1254b5f7f4b30fdb08d1cbcb406751749f2a6fc5 @croaky croaky committed Mar 10, 2013
Showing with 15 additions and 0 deletions.
  1. +15 −0 code-review/
15 code-review/
@@ -74,3 +74,18 @@ An example response to style comments:
If you disagree with a guideline, open an issue on the guides repo rather than
debating it within the code review. In the meantime, apply the guideline.
+Ruby on Rails review
+* Review data integrity closely, such as migrations that make irreversible
+ changes to the data, and whether there is a related todo to make a database
+ backup during the staging and production deploys.
+* Review SQL queries for potential SQL injection.
+* Review whether dependency upgrades include a reason in the commit message,
+ such as a link to the dependency's `ChangeLog` or `NEWS` file.
+* Review whether new database indexes are necessary if new columns or SQL
+ queries were added.
+* Review whether new scheduler (`cron`) tasks have been added and whether there
+ is a related todo in the project management system to add it during the
+ staging and production deploys.

0 comments on commit 1254b5f

Please sign in to comment.
Something went wrong with that request. Please try again.