Skip to content
This repository
Browse code

Create Ruby on Rails section of code review

Extracted from old thoughtbot development handbook.
  • Loading branch information...
commit 1254b5f7f4b30fdb08d1cbcb406751749f2a6fc5 1 parent 2ebc92a
Dan Croak croaky authored

Showing 1 changed file with 15 additions and 0 deletions. Show diff stats Hide diff stats

  1. +15 0 code-review/README.md
15 code-review/README.md
Source Rendered
@@ -74,3 +74,18 @@ An example response to style comments:
74 74
75 75 If you disagree with a guideline, open an issue on the guides repo rather than
76 76 debating it within the code review. In the meantime, apply the guideline.
  77 +
  78 +Ruby on Rails review
  79 +--------------------
  80 +
  81 +* Review data integrity closely, such as migrations that make irreversible
  82 + changes to the data, and whether there is a related todo to make a database
  83 + backup during the staging and production deploys.
  84 +* Review SQL queries for potential SQL injection.
  85 +* Review whether dependency upgrades include a reason in the commit message,
  86 + such as a link to the dependency's `ChangeLog` or `NEWS` file.
  87 +* Review whether new database indexes are necessary if new columns or SQL
  88 + queries were added.
  89 +* Review whether new scheduler (`cron`) tasks have been added and whether there
  90 + is a related todo in the project management system to add it during the
  91 + staging and production deploys.

0 comments on commit 1254b5f

Please sign in to comment.
Something went wrong with that request. Please try again.