This repository has been archived by the owner on Jul 14, 2023. It is now read-only.
Remove em() function #327
Merged
Remove em() function #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Looking good to me. |
|
Yeah looks good, let's merge this. |
tysongach
force-pushed
the
tg-remove-em-function
branch
from
b6b9108
to
38009b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per this discussion over on Bourbon, we’ll be removing the
em()function. This PR removes the use of it from Neat. It really wasn’t doing very much, any way.I made up
1200pxand am open to that being something else.