Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Fixed non-ASCII characters issue #270

Closed
wants to merge 1 commit into from
Closed

Conversation

willian
Copy link

@willian willian commented Nov 13, 2014

I'm developing an AngularJS project using gulp with gulp-ruby-sass in order to compile all the scss files. Everything worked on my machine (I have a MackBook Air, but I'm developing using Vagrant VM with Ubuntu), but when I tried to deploy it on Heroku I got:

Error in plugin 'gulp-ruby-sass'
Message:
    error /tmp/build_abab9a195c7b2366a08c918fe16ba4d5/bower_components/neat/app/assets/stylesheets/grid/_row.scss (Line 1: Invalid US-ASCII character "\xE2")

Here is the full output: https://gist.github.com/willian/673ce685f5200a93ac2d

The problem is with some non-ASCII characters in some files. I'm creating this PR to fix those files by removing non-ASCII characters.

If you want to know how I found those characters, I open the files on my Vim and I executed /[^\x00-\x7F]

PS.: I'm sorry, I updated the version because I wasn't able to test only by pointing to a commit hash.

@tysongach
Copy link
Contributor

If I’m understanding correctly, the error is isolated to _row.scss (looks like an en-dash was used), so the other four files you edited shouldn’t need to be changed; especially the README.md.

Also, fine to do a version bump for your own testing, but can you remove that from the PR and squash all commits down to one?

@willian
Copy link
Author

willian commented Nov 13, 2014

Hi Tyson, yes, I will do that right now.

@willian
Copy link
Author

willian commented Nov 13, 2014

@tysongach Done, PR is fixed.

@tysongach
Copy link
Contributor

@willian Looks like the README.md is still changed.

@foxx
Copy link

foxx commented Nov 14, 2014

Just ran into this problem, thought I was going insane.

@willian
Copy link
Author

willian commented Nov 14, 2014

@tysongach fixed =)

@tysongach
Copy link
Contributor

@willian Thanks! Can you do me a favor?

Can you add @charset "UTF-8"; to the very top of _row.scss and try again (without changing the hyphens)?

@willian
Copy link
Author

willian commented Nov 17, 2014

@tysongach Yes, I can do that.

@rbngzlv
Copy link

rbngzlv commented Nov 21, 2014

I also ran into this problem.

Adding @charset "UTF-8"; to the very top of the file, without changing the hyphens, as suggested by @tysongach also fixed the issue.

Can confirm this @willian?

@aleciafb
Copy link

aleciafb commented Dec 9, 2014

Adding @charset "UTF-8"; to the top of grid/_row.scss fixed the issue here too.

@mzgajner
Copy link

mzgajner commented Dec 9, 2014

It would still be very nice if this is fixed in Neat itself (either by adding the charset declaration or by replacing the dashes) - I usually install it with bower or npm and having to manually change the file after this prevents (elegant) automatic builds.

@tysongach tysongach added the bug label Dec 9, 2014
@tysongach tysongach mentioned this pull request Dec 9, 2014
@tysongach tysongach closed this in abb54b4 Dec 10, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants