Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow_blank signature in validate_uniqueness_of is different from that in validate_inclusion_of #721

Closed
PikachuEXE opened this issue May 20, 2015 · 6 comments
Closed

allow_blank signature in validate_uniqueness_of is different from that in validate_inclusion_of #721

PikachuEXE opened this issue May 20, 2015 · 6 comments
Labels
UX

Comments

@PikachuEXE
Copy link
Contributor

I prefer the one with optional argument
@mcmire
Copy link
Collaborator

mcmire commented May 20, 2015

Yeah, we should probably make them all optional. We should still use the explicit form in documentation, though -- I'd rather new people notice the close correlation between the matcher and the validation/association.

@PikachuEXE
Copy link
Contributor Author

Need PR?

@mcmire
Copy link
Collaborator

mcmire commented May 21, 2015

Yup, that would be great.

@mcmire mcmire added the UX label May 22, 2015
@PikachuEXE PikachuEXE mentioned this issue May 27, 2015
Closed
@PikachuEXE
Copy link
Contributor Author

#722 opened

@mcmire
Copy link
Collaborator

mcmire commented May 27, 2015

Thanks!

@maurogeorge maurogeorge mentioned this issue Jul 1, 2015
Closed
@mcmire
Copy link
Collaborator

mcmire commented Sep 22, 2015

Closing this in favor of #722.

@mcmire mcmire closed this as completed Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcmire @PikachuEXE