Remove deprecation warning for Ruby 2.4 #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jul 11, 2017
| @@ -548,7 +548,7 @@ def value_to_attribute_type(value) | |||
| case value | |||
| when true, false then :boolean | |||
| when BigDecimal then :decimal | |||
| when Fixnum then :fixnum | |||
| when Integer then :integer | |||
| @@ -538,7 +538,7 @@ def attribute_column | |||
|
|
|||
| def column_type_to_attribute_type(type) | |||
| case type | |||
| when :integer, :float then :fixnum | |||
| when :integer, :float then :integer | |||
|
@camelmasa Don't worry about it -- we'll close this when we've got it merged and link back to both of these PRs. :) |
mcmire
force-pushed
the
rails-5
branch
2 times, most recently
from
ce6dbad
to
c288843
Compare
|
Thanks for this PR! We've merged this in 03a1d21 and gave you credit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FixnumandBignumwere unified toIntegerin Ruby 2.4.https://bugs.ruby-lang.org/issues/12005
I replaced type from
FixnumtoInteger.If my changes breaks legacy versions, We can add code like
if RUBY_VERSION <= "2.4.0"for protectingshould-machersgem's legacy versions.