Doublespeak: Define #respond_to_missing? on ObjectDouble #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `delegate_method` matcher uses Doublespeak internally to do its job.
The delegate object is completely stubbed using an ObjectDouble,
available from Doublespeak, which is shoulda-matchers's own test double
library. ObjectDouble is a class that responds to every
method by implementing `method_missing`.
Say you are using Ruby 2.4 and you are testing a class that uses the
Forwardable module to do some delegation, and you are using
`delegate_method` in your test. When you run your test you will a
warning that looks something like:
Courier#deliver at ~/.rvm/rubies/ruby-2.4.0/lib/ruby/2.4.0/forwardable.rb:156 forwarding to private method #deliver
Why is this happening? When the code in your class gets exercised,
Forwardable will delegate the delegate method in question to
ObjectDouble, and the method will get intercepted by its
`method_missing` method. The fact that this is actually a private method
is what Forwardable is complaining about.
To fix this, all we need to do is add `respond_to_missing?` in addition
to `method_missing?`. This is explained here:
https://bugs.ruby-lang.org/issues/13326
houndci-bot
reviewed
Jul 25, 2017
| @@ -18,6 +18,10 @@ def respond_to?(name, include_private = nil) | |||
| true | |||
| end | |||
|
|
|||
| def respond_to_missing?(name, include_all) | |||
There was a problem hiding this comment.
Unused method argument - name. If it's necessary, use _ or _name as an argument name to indicate that it won't be used. You can also write as respond_to_missing?() if you want the method to accept any arguments but don't care about them.
Unused method argument - include_all. If it's necessary, use _ or _include_all as an argument name to indicate that it won't be used. You can also write as respond_to_missing?() if you want the method to accept any arguments but don't care about them.
|
Oh whoops! Looks like you saw it, never mind :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
delegate_methodmatcher uses Doublespeak internally to do its job.The delegate object is completely stubbed using an ObjectDouble,
available from Doublespeak, which is shoulda-matchers's own test double
library. ObjectDouble is a class that responds to every
method by implementing
method_missing.Say you are using Ruby 2.4 and you are testing a class that uses the
Forwardable module to do some delegation, and you are using
delegate_methodin your test. When you run your test you will awarning that looks something like:
Why is this happening? When the code in your class gets exercised,
Forwardable will delegate the delegate method in question to
ObjectDouble, and the method will get intercepted by its
method_missingmethod. The fact that this is actually a private methodis what Forwardable is complaining about.
To fix this, all we need to do is add
respond_to_missing?in additionto
method_missing?. This is explained here:https://bugs.ruby-lang.org/issues/13326
This fixes #1006.