Refactor ActiveRecordVersions #1423
Conversation
|
@vsppedro Yes, this makes perfect sense! I love the smell of deleted code... 😂 |
|
@mcmire, would you like this PR to be divided into smaller parts? One for each method removed in ActiveRecordVersion? I'm asking this because this PR got too big. |
vsppedro
force-pushed
the
refactor-active-record
branch
2 times, most recently
from
38ec065
to
9db871b
Compare
|
I'll add a commit for every method removed, so you can check them separately if you like. |
vsppedro
force-pushed
the
refactor-active-record
branch
from
9db871b
to
cd0ee6a
Compare
vsppedro
force-pushed
the
refactor-active-record
branch
from
bbcd43f
to
07b0670
Compare
|
@vsppedro That's fine with me. I don't mind a long PR as long as everything is all related to the same idea. Separate commits sounds good though. |
|
Done! I'm thinking of merging this PR first, after your review. After that the next to be merged I think it should be Refactor UnitUnitTests::RailsVersions. After both being merged, I think we can go with Remove Rails 5.0 support. Would you like a different approach? |
|
No problems! If you like, I can add you as a reviewer after finishing a PR. Maybe that way it’s easier to know what’s ready. What do you think? |
Yeah that makes sense. I monitor notifications on GitHub pretty frequently throughout the day, so I think it should show up then.
Yeah that sounds good to me. I've taken a look at both PRs so far and they both make sense so I'd say your plan is good! |
|
Thanks! Merging now! |
This PR is a continuation of the
Remove Rails 4.2 support- #1422.I'll keep this as a draft meanwhile the other PR is not merged.
I realized that we don't need some active record validations in the tests. The purpose of this PR is to remove conditionals that are no longer needed due to the current version that we support.
What do you think?