Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rails 5.0 support #1428

Merged
merged 4 commits into from
Mar 23, 2021
Merged

Remove Rails 5.0 support #1428

merged 4 commits into from
Mar 23, 2021

Conversation

vsppedro
Copy link
Collaborator

@vsppedro vsppedro commented Mar 7, 2021

To be honest, I think there is nothing more to be done with this version. I'm saying this after looking at the Unit Tests::ActiveRecordVersions and UnitTests::RailsVersions classes.

This PR depends on the merge of the #1426.

@vsppedro vsppedro marked this pull request as ready for review March 17, 2021 00:17
@vsppedro vsppedro requested a review from mcmire March 17, 2021 00:17
@vsppedro vsppedro mentioned this pull request Mar 17, 2021
6 tasks
@vsppedro vsppedro marked this pull request as draft March 20, 2021 21:15
@vsppedro vsppedro removed the request for review from mcmire March 20, 2021 23:21
Copy link
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems right to me. It seems like there were a lot more checks around Rails 4.2 than there were for 5.0.

@vsppedro vsppedro marked this pull request as ready for review March 23, 2021 17:14
@vsppedro
Copy link
Collaborator Author

We are getting close to the next release 😄

@vsppedro vsppedro merged commit 37ff011 into master Mar 23, 2021
@vsppedro vsppedro deleted the remove-rails-5-0 branch March 23, 2021 17:18
@vsppedro vsppedro mentioned this pull request Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants