Remove unnecessary conditions for rails 5.0

[vsppedro]

This PR is a continuation of the Refactor ActiveRecordVersions- #1423.

I'll keep this as a draft meanwhile the other PR is not merged.

[vsppedro]

Hi, @mcmire, I hope you're doing fine.

When you have some free time, would you mind taking a look at this PR and sharing your thoughts on it, please?

I think we're almost finishing removing all the support for EOL'ed Ruby and Rails releases. 🎉

[vsppedro]

I found another file that has some conditionals that we no longer need. I will remove these methods and update this PR as soon as possible.

shoulda-matchers/lib/shoulda/matchers/rails_shim.rb

Lines 6 to 12 in e746f2e

	def action_pack_gte_5?
	Gem::Requirement.new('>= 5').satisfied_by?(action_pack_version)
	end
	def action_pack_lt_5?
	Gem::Requirement.new('< 5').satisfied_by?(action_pack_version)
	end

shoulda-matchers/lib/shoulda/matchers/rails_shim.rb

Lines 20 to 22 in e746f2e

	def active_record_gte_5?
	Gem::Requirement.new('>= 5').satisfied_by?(active_record_version)
	end

[mcmire]

@vsppedro Okay, sounds good!

[vsppedro]

I think that's it. I can't find any more conditionals that need to be removed for now. What do you think?

And after the merge of this PR, it seems to me that the next should be the: Remove Rails 5.0 support.

[mcmire]

Now that there is no logic in make_controller_request, tables_and_views, and validation_message_key_for_association_required_option, what do you think about folding this code into the place where they are used so that we can remove these methods?

[vsppedro]

I think this is a good idea! I'll do that asap. Thanks!

[vsppedro]

Done!

[mcmire]

Very nice! Looks great!

[vsppedro]

Thanks!