routes test with a id is not worked.

[zw963]

spec is following:

it { should route(:get, '/api/v1/promotions/1').to(:controller => 'promotin/commons', :action => :show, id: 1) }

test failed with:

Promotion::CommonsController should route GET /api/v1/promotions/1 to/from {:controller=>"promotin/commons", :action=>"show", :id=>"1"}
     Failure/Error: it { should route(:get, '/api/v1/promotions/1').to(:controller => 'promotin/commons', :action => :show, id: 1) }
       The recognized options <{"action"=>"show", "controller"=>"promotion/commons", "id"=>"1"}> did not match <{"controller"=>"promotin/commons", "action"=>"show", "id"=>"1"}>, difference:.
       --- expected
       +++ actual
       @@ -1 +1 @@
       -{"controller"=>"promotin/commons", "action"=>"show", "id"=>"1"}
       +{"action"=>"show", "controller"=>"promotion/commons", "id"=>"1"}

spec no :id args is worked.

[zw963]

rspec: 3.1.7
rails: 4.1.0
ruby: 2.1.3p242

[zw963]

shoulda: 2.7

[mcmire]

@zw963 It looks like you have a typo: :controller => 'promotin/commons' should be :controller => 'promotion/commons', perhaps?

[zw963]

Yes, I have a typo, when I write issues.

in my own code, I have wrote like this:

  it { should route(:get, '/api/v1/promotions').to('promotion/commons#index') }
  it { should route(:get, '/api/v1/promotions/new').to('promotion/commons#new') }
  it { should route(:get, '/api/v1/promotions/1').to('promotion/commons#show', id: 1) }

first and second is worked, but, third is not worked.
if I change to:

it { should route(:get, '/api/v1/promotions/1').to(controller: 'promotion/commons', action: :show, id: 1) }

it worked OK.

Should you tell me how to write with the first way? no way ?
perhaps if provide id with hashs, we must use :controller and :action like this?

I think it should be easy to support like .to('promotion/commons#show', id: 1) } ?

[zw963]

a found a comments in source code:

      #     route(:get, '/posts/1').to('posts#show', id: 1)

seem like shoulda support this form, But I use a nest controller, it not worked~

here is all backtrace in spec:

  1) Promotion::CommonsController should route GET /api/v1/promotions/1 to/from {:id=>1, :controller=>"promotion/commons", :action=>"show"}
     Failure/Error: it { should route(:get, '/api/v1/promotions/1').to('promotion/commons#show', id: 1) }
       The recognized options <{"action"=>"show", "controller"=>"promotion/commons", "id"=>"1"}> did not match <{"id"=>1, "controller"=>"promotion/commons", "action"=>"show"}>, difference:.
       --- expected
       +++ actual
       @@ -1 +1 @@
       -{"id"=>1, "controller"=>"promotion/commons", "action"=>"show"}
       +{"action"=>"show", "controller"=>"promotion/commons", "id"=>"1"}
     # ./test/controllers/promotion/commons_controller_test.rb:18:in `block (2 levels) in <top (required)>'
     # /home/zw963/.rvm/gems/ruby-2.1.3@neil-rails-app/gems/activesupport-4.1.0/lib/active_support/dependencies.rb:241:in `load'
     # /home/zw963/.rvm/gems/ruby-2.1.3@neil-rails-app/gems/activesupport-4.1.0/lib/active_support/dependencies.rb:241:in `block in load'
     # /home/zw963/.rvm/gems/ruby-2.1.3@neil-rails-app/gems/activesupport-4.1.0/lib/active_support/dependencies.rb:232:in `load_dependency'
     # /home/zw963/.rvm/gems/ruby-2.1.3@neil-rails-app/gems/activesupport-4.1.0/lib/active_support/dependencies.rb:241:in `load'
     # -e:1:in `<main>

[mcmire]

@zw963 Thanks for the update. So it looks like the difference is that you're passing an integer in for id but apparently when it interprets the path the id ends up being a string. This is odd because we have a test for this: https://github.com/thoughtbot/shoulda-matchers/blob/master/spec/shoulda/matchers/action_controller/route_matcher_spec.rb#L35. It isn't exactly the same though, so maybe there's something small that's affecting this. Can you clone the repo and add a failing test for this and see if you can reproduce it that way?

[zw963]

#603

[zw963]

Another problem, When I run spec, found Gemfile missing some gem, e.g. jquery-rails, sass-rails, etc..

Should I add a new issue for this ?

[mcmire]

Did you run bundle and appraisal install first?

[zw963]

What I did is just run bundle install in a new gemset, and then rspec, it not worked, missing some gems,

in `block in retrying': Command 'bundle install --local' failed: (RuntimeError)
Resolving dependencies...
Could not find gem 'jquery-rails (>= 0) ruby' in the gems available on this machine.

add I add following missing gem to Gemfile, it can worked now.

gem 'jquery-rails'
gem 'coffee-rails'
gem 'sass-rails'
gem 'uglifier'

[zw963]

@mcmire , Cool, I does not run appraisal install. it solved!
though, this name is too complex for non-english language.

[mcmire]

Haha, yeah, appraisal is kind of a funny name.

[zw963]

Cool~ hope to fixed soon.

[mcmire]

@zw963 If you could take a look at #603, I made some comments there about the test you wrote. If you could fix that up and confirm you're getting the same error as you did before, that would help a bunch. Thanks.

[zw963]

@mcmire , Hi, I add more spec for reproduce my case, hope it could help.

[mcmire]

Fixed in abb087e.