Support qualifier(optional, required) of 'belongs_to' #956
Conversation
I don't take care implements, it only care correct option passed or not, and its value is boolean or not. Validating this qualifier is supported or not doesn't seem its role. In that case ActiveRecord will notice that loudly.
| if option_verifier.correct_for_boolean?(:optional, options[:optional]) | ||
| true | ||
| else | ||
| @missing = "#{name} should have optional set to #{options[:optional]}" |
| @@ -975,6 +986,8 @@ def matches?(subject) | |||
| primary_key_exists? && | |||
| class_name_correct? && | |||
| join_table_correct? && | |||
| required_correct? && # TODO: Removed when Rails 4.2 support finished. | |||
|
Cool, thanks for this. This looks good, although of course you're right, we will need to make sure that this works with Rails 5. I'm going to start working on adding Rails 5 support soon, and I'll have to come back to this when that's done. But for now I've tagged this issue appropriately to remind myself. |
|
Ok, then I will update documents soon :) |
| # TODO: Removed when Rails 4.2 support finished. | ||
| def required_correct? | ||
| if options.key?(:required) | ||
| if option_verifier.correct_for_boolean?(:required, options[:required]) |
|
What's the status on this? Anything I might be able to help with? |
|
@JoeWoodward This PR is dependent on adding support for Rails 5 (#960). So it can't be finished and merged until that is complete. I really haven't had time to work on this gem, by the way, so if you're looking to help out, that's the number item to finish right now. |
|
@mcmire I'll try to look into this. By the way, I use this gem with Rails 5 and besides this haven't experienced any issues. By the way, would it make sense to support that |
|
@edwardmp Yes, that would be the manual way to test it. So the should belong_to(:association_name).and.validate_presence_of(:association_name) |
riseshia/optional Support qualifier(optional, required) of 'belongs_to'
|
@riseshia I realize it's been a long time, but thank you for this PR! I've taken your changes and put them into a new PR with additional tweaks: #1058. Instead of merely checking that the association has a |
related to #870, #861
This is to support qualifiers(optional, required) of
belongs_to, Please review and let me know if it seems good. Then I will write documents for this :)btw, there is one problem, test suites require
protected_attributesgem so that we could not run test with rails 5 environment. ;(Hence, I could grant
requiredworks well(with rails 4.2) with test, but notoptionalwith rails 5.x.Because of this, I had to confirm whether these work well or not in my personal rails 5 project.
anyway, we need to support test with rails 5 environment.
Thanks for reading this. 👍