Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vm client #202

Closed
ashraffouda opened this issue Sep 3, 2023 · 1 comment
Closed

fix vm client #202

ashraffouda opened this issue Sep 3, 2023 · 1 comment
Assignees
Milestone

Comments

@ashraffouda
Copy link
Contributor

the current vm client is not aligned at all with the current server side implementation
the methods in server side is not reflecting the correct implementation for example
in this line the machine name is different from the network name while in the code it expects to be the same as here
also the code expects to deploy many vms while in server side it is only deployes one vm
so this needs to be fixed or refactored

@despiegk
Copy link
Contributor

despiegk commented Oct 9, 2023

new story will be created which should also catch this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants