Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When TFTs are burned during billing, this should be handled in the bridges as well #731

Open
robvanmieghem opened this issue Apr 23, 2022 · 5 comments
Labels
type_feature New feature or request
Milestone

Comments

@robvanmieghem
Copy link
Contributor

The amount of TFT's burned should be removed from the vaults from connected bridges as well and burned too.

@robvanmieghem robvanmieghem added the type_feature New feature or request label Apr 23, 2022
@DylanVerstraete DylanVerstraete transferred this issue from threefoldtech/tfchain May 24, 2022
@DylanVerstraete DylanVerstraete added this to the later milestone Mar 23, 2023
@DylanVerstraete DylanVerstraete transferred this issue from threefoldtecharchive/tfchain_tft_bridge Jun 7, 2023
@sameh-farouk
Copy link
Member

sameh-farouk commented Feb 28, 2024

Burning tokens in tfchain can happen in one of three scenarios:
1- Voluntary Token Burning: Users can voluntarily burn their tokens using the Burning pallet(
burnTft call).
2- Cultivation Rewards Distribution: During cultivation rewards distribution, 35% of rewards tokens are burned as part of the process. This occurs within the smartContract pallet.
3- Swap tokens from tfchain to stellar via TFT-Bridge: When a swap is initiated via the TFTbridge pallet (swapToStellar call), the bridge handles the burn transaction by sending an equal amount of tokens to a Stellar destination address.

I propose emitting an event to track the amount burned in the first two scenarios. The bridge can handle this event similarly, with the exception that the destination address is the Stellar TFT issuer account.

Note: We can consider the removal of burnTft public call unless there is a good reason to keep it around.

@scottyeager
Copy link

The plan now is to end the burning of TFT on TF Chain as part of the billing flow so we can have a supply of precisely 1B TFT.

With that in mind, I don't think it makes sense to automate this process on the bridge. We can just perform a manual burn of Stellar TFT to remove the supply burned on TF Chain. Or perhaps do one now and one more once the burning has stopped.

I'd agree to close the public access to the burn function.

@renauter renauter modified the milestones: later, 2.8.0 Mar 21, 2024
@sameh-farouk
Copy link
Member

The plan now is to end the burning of TFT on TF Chain as part of the billing flow so we can have a supply of precisely 1B TFT.

I’m curious about the timing of this event. We’re currently burning tokens as part of the cultivation rewards distribution, and as far as I know, there haven’t been any requirements communicated to the development team regarding removing this logic from the chain, nor has any issue been opened regarding this.

@sameh-farouk
Copy link
Member

I don't think it makes sense to automate this process on the bridge. We can just perform a manual burn of Stellar TFT to remove the supply burned on TF Chain. Or perhaps do one now and one more once the burning has stopped.

I have no issue with any of these options, as long as we address the inflation.

@scottyeager
Copy link

I’m curious about the timing of this event.

We are finalizing the GEP to do this and will present it to the community very soon. Assuming the GEP is passed, then we'll make a plan to implement this.

@sameh-farouk sameh-farouk modified the milestones: 2.8.0, later Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants