Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for mvn eclipse:eclipse to work #5

Closed
tmjee opened this issue Dec 5, 2011 · 4 comments
Closed

Patch for mvn eclipse:eclipse to work #5

tmjee opened this issue Dec 5, 2011 · 4 comments

Comments

@tmjee
Copy link

tmjee commented Dec 5, 2011

Hi guys,

I know this is a very trivial patch, but it really helps me to get mvn eclipse:eclipse to work. Currently without the following mvn eclipse:eclipse failed with the following nasty error

         Failed to execute goal org.apache.maven.plugins:maven-eclipse-plugin:2.8:eclipse (default-cli) on project playn-archetype

Guessing that it got some internal conflict when no maven eclipse plugin is specified. The fix is pretty simple, just add specify a version of maven eclipse plugin in playn/pom.xml would fix it.

         <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-eclipse-plugin</artifactId>
        <version>2.6</version>
        <configuration>
          <ajdtVersion>1.6</ajdtVersion>
        </configuration>
      </plugin>

If someone could help patch this in that'd be great, else people would have to manually put this in everything they do a git pull which could be rather annoying at times. Cheers

@fredsa
Copy link
Contributor

fredsa commented Dec 5, 2011

mvn eclipse:eclipse works for me after creating default projects after the plan-archetype

Once imported into Eclipse there are two errors in the mygame-html project though:

  1. CHKJ3008E: Missing or invalid WAR file.
  2. The project 'zzz-html' does not have any GWT SDKs on its build path

I don't see those errors if I instead just import the (existing maven) projects into Eclipse directly and let Eclipse create the .classpath, .settings, .project files

Have you tried the latest archetype?

@tmjee
Copy link
Author

tmjee commented Dec 5, 2011

Thanks for the reply. I'm not trying mvn eclipse:eclipse on generated playn
project, pretty sure it'd work as you've said.

Did a mvn eclipse:eclipse on PlayN project itself and it failed me while
generating eclipse specific files for some of the modules like the
archetype module in PlayN. I'm guessing with the whole bunch of
dependencies maven seems to come up with different version of
maven-eclipse-plugin to use with each module and got confuse in the
process. Specifying a specific version of maven-eclipse-plugin seems to fix
the issue though.

Cheers
Toby

On Tue, Dec 6, 2011 at 9:11 AM, fredsa <
reply@reply.github.com

wrote:

mvn eclipse:eclipse works for me after creating default projects after the
plan-archetype

Once imported into Eclipse there are two errors in the mygame-html project
though:

  1. CHKJ3008E: Missing or invalid WAR file.
  2. The project 'zzz-html' does not have any GWT SDKs on its build path

I don't see those errors if I instead just import the (existing maven)
projects into Eclipse directly and let Eclipse create the .classpath,
.settings, .project files

Have you tried the latest archetype?


Reply to this email directly or view it on GitHub:
#5 (comment)

@samskivert
Copy link
Member

We don't support using "mvn eclipse:eclipse" to build PlayN itself. You have to use the m2eclipse plugin (which is built into the most recent versions of Eclipse). See http://code.google.com/p/playn/wiki/CheckoutReviewCommit

mvn eclipse:eclipse is a primitive approach that doesn't handle all of the complexities needed for the PlayN build and if it isn't already broken, it will be in the future.

@tmjee
Copy link
Author

tmjee commented Dec 7, 2011

Ok, nice. :-)

On Wed, Dec 7, 2011 at 10:22 AM, Michael Bayne <
reply@reply.github.com

wrote:

We don't support using "mvn eclipse:eclipse" to build PlayN itself. You
have to use the m2eclipse plugin (which is built into the most recent
versions of Eclipse). See
http://code.google.com/p/playn/wiki/CheckoutReviewCommit

mvn eclipse:eclipse is a primitive approach that doesn't handle all of the
complexities needed for the PlayN build and if it isn't already broken, it
will be in the future.


Reply to this email directly or view it on GitHub:
#5 (comment)

samskivert added a commit that referenced this issue Jan 2, 2014
Analytics was only ever implemented on the HTML5 backend and was never going to
be implemented meaningfully on any other backend.

RegularExpression was Java's regexp on Java/Android and HTML's regexp on HTML5,
which are incompatible. Better to leave games to fend for themselves (and do
things safely in a per-platform manner) than to pretend that a cross-platform
API for something as complex as regexps could possibly exist.

If you need consistent cross platform behavior, bundle a pure Java regexp
library with your game. If you need high performance, implement exactly what
you need, tweaked specifically to work for HTML's regexps and Java's regexps in
your own per-backend code. Or if you never plan to run your game in HTML5, then
just use java.util.regex.Pattern directly.

In theory these should have gone through a deprecation cycle, but they're both
so half-assed that no one could possibly have been seriously relying on them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants