Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed submit_blob will still end up in returned blobs #71

Closed
pepyakin opened this issue Nov 29, 2023 · 3 comments
Closed

Failed submit_blob will still end up in returned blobs #71

pepyakin opened this issue Nov 29, 2023 · 3 comments

Comments

@pepyakin
Copy link
Contributor

pepyakin commented Nov 29, 2023

It's possible that when shim returns blobs for a specific namespace (for sovereign dock at minimum), it would attempt to create proofs of inclusion. However, some of the blobs may potentially fail to be included. Those submit blob extrinsics would still be present in the block, and as such will be returned in the resulting "blobs" field. By default the sovereign adapter would treat them as all of them included. At the same time the inclusion proof would not contain the failed blobs. Therefore, I would expect that this inclusion proof will fail verification.

This would be solved if we did not allow the invalid blobs in blocks as per #74

@rphmeier
Copy link
Contributor

IMO this issue should be a comment in #74 as it is directly caused by #74

@pepyakin
Copy link
Contributor Author

pepyakin commented Dec 4, 2023

Disagree for the general case.

Issues evolve, grow and shrink in scope. It happens that an issue is closed when not all aspects/problems are fixed. Therefore IMO it's better to risk having two different issues for the same thing than having two things on one issue. The downside of this approach is that the discoverability decreases and the discussion smears over, but not too concering at this moment.

@rphmeier
Copy link
Contributor

Can be closed now - invalid blobs now cause panics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants