Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we use torch.compile? #1114

Open
MischaPanch opened this issue Apr 15, 2024 · 2 comments
Open

Should we use torch.compile? #1114

MischaPanch opened this issue Apr 15, 2024 · 2 comments
Assignees
Labels
optimization Performance optimization (throughout, memory, processing speed)

Comments

@MischaPanch
Copy link
Collaborator

We should analyze whether using the newest pytorch acceleration tricks gives performance boosts. At least for some algos on atari, and for some on mujoco.

If it is useful, we should by default user torch.compile for all our networks. Maybe it even makes sense to do that without much testing, as I suppose that torch.compile won't have negative effects. It would be interesting to know the amount of speedup though.

Tests have to be executed on a GPU, maybe colab is sufficient.

@MischaPanch MischaPanch added the optimization Performance optimization (throughout, memory, processing speed) label Apr 15, 2024
@MischaPanch
Copy link
Collaborator Author

@arnaujc91 wanna have a look?

@arnaujc91
Copy link
Contributor

Yes, can you assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Performance optimization (throughout, memory, processing speed)
Projects
None yet
Development

No branches or pull requests

2 participants