-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doctor: fix errors when there is no config #1397
Conversation
Hey good catch! Do you mind adding a test for when there's no config? I missed that one. There's a test file that tests doctor outputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, pending only adding a unit test.
331b300
to
5d0f828
Compare
Gotta fix another bug :( Sorry. There's a sys.exit if no errors found and that sys.exit should also respect the exit flag. |
Just need to update the snapshot and you should be good to go :) |
67c2ef8
to
5e190b1
Compare
You force-pushed over my change :( |
Just remove the sys.exit from the print message method. |
5e190b1
to
233071c
Compare
I'm sorry!
Did you add |
233071c
to
815f3f7
Compare
Nope and you shouldn't, otherwise tests will never break. The idea of snapshots is that you look at the snapshot and it is what you expect, then it never changes (unless the functionality changes). This ensures the result is always the same. |
No description provided.