Handle invalid images and return a 400 or 500 depending on the cause #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you VERY much @masom! You are doing an incredible job! |
heynemann
added a commit
that referenced
this pull request
Aug 20, 2015
Handle invalid images and return a 400 or 500 depending on the cause
|
The downside here is that we need to check the other PR to make sure if we need to rebase before accepting. |
|
awesome, thanks guys |
|
We'll release a new version soon. |
christianjgreen
pushed a commit
to fanhero/thumbor
that referenced
this pull request
Aug 29, 2017
Handle invalid images and return a 400 or 500 depending on the cause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent thumbor from hanging when the engine or loader throw an exception.
Handle exceptions thrown by the
BaseHandler._fetchmethod. If the exception is thrown by Pillow ( IOError with a specific message ) the response code is set to 400 ( invalid request ).Related to #531
Helps with #528, #537