fixes #808 - requests hangs in engine.read exception #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2017
|
Thanks for the contribution, @savar. Can you please add tests for this? |
|
@scorphus I'll try to add tests. |
in case an exception is thrown inside the engine.read() method the exception was either not catched properly (in case the THREADPOOL size is >0) or the result was not a tuple and the unpacking waits for more data while calling .result() (in case the THREADPOOL size is 0)
the ThreadPoolWorker is using _WorkerItems() wrapping the Future() and using the Future().set_exception() method so the exception is thrown at the Future().result() call so it is similar to what happens when using the ThreadPoolWorker
|
@scorphus I fixed the checks but to be honest the part I would like to test (the function passing the |
|
Thanks, @savar!
Keep an eye on upcoming tests 😉 |
scorphus
added a commit
to scorphus/thumbor
that referenced
this pull request
Mar 10, 2017
Also add another test for thumbor#871
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in case an exception is thrown inside the engine.read() method the
exception was either not catched properly (in case the THREADPOOL size
is >0) or the result was not a tuple and the unpacking waits for more
data while calling .result() (in case the THREADPOOL size is 0)