Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #808 - requests hangs in engine.read exception #871

Merged
merged 6 commits into from Mar 10, 2017
Merged

fixes #808 - requests hangs in engine.read exception #871

merged 6 commits into from Mar 10, 2017

Commits on Mar 6, 2017

  1. fixes thumbor#808 - requests hangs in engine.read exception 

    in case an exception is thrown inside the engine.read() method the
exception was either not catched properly (in case the THREADPOOL size
is >0) or the result was not a tuple and the unpacking waits for more
data while calling .result() (in case the THREADPOOL size is 0)
    @savar
    savar committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    05ddbf6 View commit details
    Browse the repository at this point in the history

  2. better comment

    @savar
    savar committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    76cc4b9 View commit details
    Browse the repository at this point in the history

  3. remove unused import

    @savar
    savar committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    5a06d36 View commit details
    Browse the repository at this point in the history

  4. following more the original ThreadPoolWorker way 

    the ThreadPoolWorker is using _WorkerItems() wrapping the Future()
and using the Future().set_exception() method so the exception is
thrown at the Future().result() call so it is similar to what happens
when using the ThreadPoolWorker
    @savar
    savar committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    119c15f View commit details
    Browse the repository at this point in the history

  5. fixing checks with the new aproach

    @savar
    savar committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    bc124e5 View commit details
    Browse the repository at this point in the history

  6. fix wrong logging

    @savar
    savar committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    a4b5a4f View commit details
    Browse the repository at this point in the history