Disallow Join button without IP address input

Disallow join button without IP address Input Closes OpenRA#20234 Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input. Updated to reuse search for joinButton vs 2 separate calls to search.
thumperward · Sep 9, 2022 · 20e00c1 · 20e00c1
1 parent dbfbd2e
commit 20e00c1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/OpenRA.Mods.Common/Widgets/Logic/DirectConnectLogic.cs b/OpenRA.Mods.Common/Widgets/Logic/DirectConnectLogic.cs
@@ -39,7 +39,11 @@ public DirectConnectLogic(Widget widget, Action onExit, Action openLobby, Connec
 				portField.Text = text.Substring(last + 1);
 			}
 
-			panel.Get<ButtonWidget>("JOIN_BUTTON").OnClick = () =>
+			var joinButton = panel.Get<ButtonWidget>("JOIN_BUTTON");
+
+			joinButton.IsDisabled = () => string.IsNullOrEmpty(ipField.Text);
+
+			joinButton.OnClick = () =>
 			{
 				var port = Exts.WithDefault(1234, () => Exts.ParseIntegerInvariant(portField.Text));