Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to join a server with an empty address crashes the game #20234

Closed
dragunoff opened this issue Aug 30, 2022 · 1 comment · Fixed by #20272
Closed

Trying to join a server with an empty address crashes the game #20234

dragunoff opened this issue Aug 30, 2022 · 1 comment · Fixed by #20272
Labels
Crash

Comments

@dragunoff
Copy link
Contributor

I don't expect many people to try that but still it shouldn't happen. The "Join" button should be disabled if the address field is empty.

image

System Information

  • Operating System: any
  • OpenRA Version: bleed
  • OpenRA Mod: any

Exception log

OpenRA engine version release-20210321
Tiberian Dawn mod version release-20210321
Date: 2022-08-30 13:03:18Z
Operating System: Linux (Unix 5.15.0.46)
Runtime Version: Mono 6.4.0.198 (tarball Tue Sep 24 01:20:30 UTC 2019) CLR 4.0.30319.42000
Exception of type `System.ArgumentException`: The parameter 'host' cannot be an empty string.
  at System.Net.DnsEndPoint..ctor (System.String host, System.Int32 port, System.Net.Sockets.AddressFamily addressFamily) [0x00034] in <2703bbaa0a6e4686b6033c2dddb1a363>:0 
  at System.Net.DnsEndPoint..ctor (System.String host, System.Int32 port) [0x00000] in <2703bbaa0a6e4686b6033c2dddb1a363>:0 
  at OpenRA.Network.ConnectionTarget..ctor (System.String host, System.Int32 port) [0x00006] in <24adfa0d4e934ea8abdc965bd2260629>:0
@The-Zen-Cat The-Zen-Cat mentioned this issue Sep 8, 2022
Merged
@The-Zen-Cat
Copy link
Contributor

Submitted pull request that fixes issue by disallowing user to press join button until there in input in Address: field

The-Zen-Cat added a commit to The-Zen-Cat/OpenRA that referenced this issue Sep 8, 2022
@The-Zen-Cat
Disallow join button without IP address Input
818a4f8 
Closes OpenRA#20234

Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input.  Updated to reuse search for joinButton vs 2 separate calls to search.
The-Zen-Cat added a commit to The-Zen-Cat/OpenRA that referenced this issue Sep 8, 2022
@The-Zen-Cat
Disallow Join button without IP address input
b2e6d94 
Disallow join button without IP address Input

Closes OpenRA#20234

Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input.  Updated to reuse search for joinButton vs 2 separate calls to search.
PunkPun pushed a commit that referenced this issue Sep 9, 2022
@The-Zen-Cat @PunkPun
Disallow Join button without IP address input
125a7b8 
Disallow join button without IP address Input

Closes #20234

Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input.  Updated to reuse search for joinButton vs 2 separate calls to search.
Zero-Fanker pushed a commit to OpenRA-CN/OpenRA that referenced this issue Mar 6, 2023
@The-Zen-Cat @dnqbob
Disallow Join button without IP address input
c4c976c 
Disallow join button without IP address Input

Closes OpenRA#20234

Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input.  Updated to reuse search for joinButton vs 2 separate calls to search.
thumperward pushed a commit to thumperward/OpenRA that referenced this issue Oct 9, 2023
@The-Zen-Cat @PunkPun
Disallow Join button without IP address input
20e00c1 
Disallow join button without IP address Input

Closes OpenRA#20234

Trying to join a server with an empty address crashes the game. This fix disallows pressing join button without ip address field input.  Updated to reuse search for joinButton vs 2 separate calls to search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Crash
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow Join button without IP address input The-Zen-Cat/OpenRA
2 participants
@dragunoff @The-Zen-Cat