Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for full screen swipe-to-go-back #312

Closed
sageDieu opened this issue Jul 10, 2023 · 20 comments
Closed

Add option for full screen swipe-to-go-back #312

sageDieu opened this issue Jul 10, 2023 · 20 comments
Labels
enhancement New feature or request

Comments

@sageDieu
Copy link

Is your feature request related to a problem? Please describe.
I tend to prefer swipe actions for navigation, and in Apollo and other similar apps I'm usually able to turn on an option to swipe anywhere on the page to go back to the previous.

Describe the solution you'd like
For a quick example check out the HackerNews app HACK: https://apps.apple.com/us/app/hack-for-hacker-news-reader/id1464477788

Enable the setting for "full screen swipe to go back" and then go load a post and swipe anywhere on the screen to go back to the list of posts.

@sageDieu sageDieu added the enhancement New feature or request label Jul 10, 2023
@micahmo
Copy link
Member

micahmo commented Jul 10, 2023

Related to #198.

@jordan1776
Copy link

Personally I would rather have partial screen swipe to go back rather than full screen so you could both have comment gestures and swipe back at the same time. This type of action is already used for the side menu on the feed view.

@micahmo
Copy link
Member

micahmo commented Jul 10, 2023

you could both have comment gestures and swipe back at the same time

One idea: Relay uses right-to-left for back and left-to-right for post/comment gestures.

@thepaperpilot
Copy link

As another relay user, I'd also like to be able to swipe right to go back. Now that the swipe gestures are customizable, I'd love to have something that just entirely disabled swiping right on comments to allow going back instead

@jordan1776
Copy link

, I'd love to have something that just entirely disabled swiping right on comments to allow going back instead

Maybe the swipe settings should have up to 4 on the right side for emulating Relay and 2 on the left for Apollo, with the option to set the 2nd, 3rd, and 4th actions to none. And if both left side actions are set to none, use the full screen swipe.

@Fmstrat
Copy link
Contributor

Fmstrat commented Jul 11, 2023

This needs to be considered for iOS vs Android. Newer versions of Android have a default swipe back action. iOS will probably steal this in the future, but for now, if this is implemented it may need to be platform specific.

@hjiangsu
Copy link
Member

For swiping right to go back, iOS already has that natively (I can swipe right from any screen to go to the previous screen) I didn't fully realize that this was not the case for Android (I'm guessing it depends on the OS version or variant)

The one thing I'm wondering about with the full screen swipe is how it interferes with swipe gestures. Would swipe gestures on comments/posts need to be turned off for this to work or is there a way that both of them can work together?

@micahmo
Copy link
Member

micahmo commented Jul 11, 2023

is there a way that both of them can work together?

Not saying this is the best answer, but one thing we discussed in this thread is having left-to-right go back and right-to-left for gestures. We might want up to four gestures per side in that case though.

@CTalvio
Copy link
Collaborator

CTalvio commented Jul 14, 2023

For swiping right to go back, iOS already has that natively (I can swipe right from any screen to go to the previous screen) I didn't fully realize that this was not the case for Android (I'm guessing it depends on the OS version or variant)

The one thing I'm wondering about with the full screen swipe is how it interferes with swipe gestures. Would swipe gestures on comments/posts need to be turned off for this to work or is there a way that both of them can work together?

Newer android versions do support system gestures as well, though some user have stuck with old three softbutton navbar, and some phone brands do not use gesture navigation by default.

The screen edge back gesture is different from the full screen gesture used by relay, and obviously cannot be used if you've not enabled the new gesture navbar.

@hjiangsu
Copy link
Member

hjiangsu commented Aug 8, 2023

This has been implemented (without the toggle) in the latest pre-release. Let me know your thoughts!

If there is a left-to-right action, then full page swipe is disabled and you can only go back when swiping from the left. Otherwise, it should be enabled

@hjiangsu hjiangsu added the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Aug 8, 2023
@hjiangsu hjiangsu added this to the v0.2.1+14 milestone Aug 8, 2023
@thepaperpilot
Copy link

It's great to see it coming along! I've personally found it really hard to swipe precisely enough to get it to work, though. Could it be more forgiving about the exact angle? For example, give 45 degree leeway either direction.

@hjiangsu
Copy link
Member

hjiangsu commented Aug 8, 2023

Do you have any left-to-right gestures enabled? If you do, then swiping back will only get triggered from the edge of the screen

You can try these settings and let me know if you're still having trouble!

image

@micahmo
Copy link
Member

micahmo commented Aug 8, 2023

I've personally found it really hard to swipe precisely enough to get it to work, though.

@hjiangsu Yeah, unfortunately after daily driving this on my physical device, I'm finding it's a bit inconsistent as well. I can't tell if it's not recognizing the gesture or getting totally disabled sometimes, but it was weird. Maybe needs some more tweaking.

@hjiangsu
Copy link
Member

hjiangsu commented Aug 8, 2023

Dang okay, maybe we need to refine this a bit more somehow then. Maybe just list out some of the screens that you're experiencing this on, and how you're performing the swipe gesture and we can narrow it down

@micahmo
Copy link
Member

micahmo commented Aug 8, 2023

If I get a chance alter I'll try to do a screen recording with touches on so you can see what's happening.

@micahmo
Copy link
Member

micahmo commented Aug 9, 2023

@hjiangsu GitHub is having trouble playing the recording from my physical device (probably a format issue), so I DM'd you in Matrix.

@micahmo
Copy link
Member

micahmo commented Sep 6, 2023

This has been added to the latest general release. However, the functionality seems to be a bit hit-or-miss on Android. While this is still being investigated I'll leave this issue open.

@micahmo micahmo removed the fixed in upcoming release Indicates that an issue has been fixed, and will be released in the next version label Sep 6, 2023
@micahmo micahmo removed this from the v0.2.1+14 milestone Sep 6, 2023
@micahmo
Copy link
Member

micahmo commented Sep 30, 2023

Just circling back on this issue... I happened to notice that swiping back on the center FAB is very consistent! This leads me to believe our original conclusion was correct that there is still some conflict of gestures with the comments (Dismissible).

@micahmo
Copy link
Member

micahmo commented Jul 15, 2024

Hey @hjiangsu, two questions!

Do you think this is a dup of #198?

Do think it can be closed as a result of #1363? As I commented on #1413, this has been working much more consistently for me now!

@hjiangsu
Copy link
Member

I think we can close this then, if you're noticing better consistency in the new post page! I haven't had too many issues personally on this, so it's hard for me to comment whether or not this is fixed or not 😅

@micahmo micahmo closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants