Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new dark theme is brownish and not black (harder to read) #7864

Closed
2 tasks done
AnthillSudoku opened this issue May 22, 2024 · 22 comments
Closed
2 tasks done

new dark theme is brownish and not black (harder to read) #7864

AnthillSudoku opened this issue May 22, 2024 · 22 comments
Labels
tb-team Tasks and features handled by project maintainers type: bug Something is causing incorrect behavior or errors type: UI/UX Visual or UX design issues

Comments

@AnthillSudoku
Copy link

AnthillSudoku commented May 22, 2024

Checklist

  • I have used the search function to see if someone else has already submitted the same bug report.
  • I will describe the problem with as much detail as possible.

App version

6.901

Where did you get the app from?

Other

Android version

12

Device model

samsung a52q

Steps to reproduce

Old dark theme wasn't pure black and did not support amoled feature, but at least it were easier to read. The new even has even less contrast between the background and the text, making it harder to read.

new dark theme

Imagepipe_1

I put the screenshot of the left pane, but the same goes for the messages list and message UI

old dark theme

Imagepipe_0

Expected behavior

dark theme is close to black

Actual behavior

Dark theme is brownish

Logs

No response

@AnthillSudoku AnthillSudoku added type: bug Something is causing incorrect behavior or errors unconfirmed Newly reported issues awaiting triage or confirmation labels May 22, 2024
@AnthillSudoku
Copy link
Author

While here #7856 the issue already came out in the comments, the submitter asked for more colors and did not focus on black theme

@wmontwe
Copy link
Member

wmontwe commented May 22, 2024

There are some known contrast issues with the new dark color scheme and we're working on a fix.

@wmontwe wmontwe added type: UI/UX Visual or UX design issues tb-team Tasks and features handled by project maintainers and removed unconfirmed Newly reported issues awaiting triage or confirmation labels May 22, 2024
@uniquePWD
Copy link

It should probably be noted that black doesn't fair well with user experience research

@cketti
Copy link
Member

cketti commented May 29, 2024

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

@uniquePWD
Copy link

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

https://tatham.blog/2008/10/13/why-light-text-on-dark-background-is-a-bad-idea/

https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/

@MillionsToOne
Copy link

That is just pure propaganda from light mode users. Even common sense should tell you to not be on a computer all the time.

@baccyflap
Copy link

The idea that white-on-not-quite-black (or gray-on-white) is somehow more legible than black-and-white is a pervasive one. This NN article is the closest thing I could find to a reliable source, though it doesn't explicitly discuss dark mode - it just recommends high contrast overall, much like W3C.

There are some inconclusive small-scale studies which seem to be mostly from the 90s and early 2000s, when displays looked rather different. All the rest seems to be down to preference and UX fairystories - talk of 'cool blacks' and 'warm grays', that sort of thing.

@thatguy764
Copy link

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

https://tatham.blog/2008/10/13/why-light-text-on-dark-background-is-a-bad-idea/

https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/

Pissing off your user base by suddenly changing the look and feel they've used for years also creates a bad user experience. Not everyone will necessarily want to use the "super ergonomic better for your eyes solarized IDE" style option and that's okay, even if using something like the current existing dark mode is slightly more eye straining for them. That is of course even assuming this research is accurate, if I'm recalling correctly a lot of human factors research on eye strain was done during the CRT era, and I'm sure some was done during the LCD era, and now we're split between those and OLEDs so it's not even universal at the moment. It's also worth keeping in mind that most UX research is best practices or guidelines at best, it's rarely by any means definitive so you should always take it with a grain of salt and not try to wield it like a big stick.

Given that the point of free software is user choice, leaving the traditional dark mode as an option along with one or more ergonomic/accessibility style themes seems like a pretty reasonable middle ground.

@MillionsToOne
Copy link

I think it would be helpful to anyone reading this if you provided links to relevant user experience research.

https://tatham.blog/2008/10/13/why-light-text-on-dark-background-is-a-bad-idea/

https://uxmovement.com/content/why-you-should-never-use-pure-black-for-text-or-backgrounds/

Pissing off your user base by suddenly changing the look and feel they've used for years also creates a bad user experience. Not everyone will necessarily want to use the "super ergonomic better for your eyes solarized IDE" style option and that's okay, even if using something like the current existing dark mode is slightly more eye straining for them. That is of course even assuming this research is accurate, if I'm recalling correctly a lot of human factors research on eye strain was done during the CRT era, and I'm sure some was done during the LCD era, and now we're split between those and OLEDs so it's not even universal at the moment. It's also worth keeping in mind that most UX research is best practices or guidelines at best, it's rarely by any means definitive so you should always take it with a grain of salt and not try to wield it like a big stick.

Given that the point of free software is user choice, leaving the traditional dark mode as an option along with one or more ergonomic/accessibility style themes seems like a pretty reasonable middle ground.

All I can say is "Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."

@baccyflap
Copy link

I'd be interested in an update on this bug, if it's available; the inexplicable brown colouration is driving me a little nuts.

@MillionsToOne
Copy link

I'd be interested in an update on this bug, if it's available; the inexplicable brown colouration is driving me a little nuts.

It isn't a bug. MD3 and MY is a work-in-progress, so MY colors haven't been merged yet. Otherwise it would use wallpaper colors. You can stay on latest stable release if colors bother you.

@baccyflap
Copy link

Yes sorry, an issue rather than a bug. So once that's finished, it'll use wallpaper colours? That'd solve the issue for everyone, I imagine.

@MillionsToOne
Copy link

MillionsToOne commented Jul 1, 2024

Yes sorry, an issue rather than a bug. So once that's finished, it'll use wallpaper colours? That'd solve the issue for everyone, I imagine.

https://github.com/orgs/thunderbird/projects/4/views/7

In the Material 3 section.

@MillionsToOne
Copy link

Yes sorry, an issue rather than a bug. So once that's finished, it'll use wallpaper colours? That'd solve the issue for everyone, I imagine.

#6617 (comment)

@marek22k
Copy link

marek22k commented Oct 2, 2024

Is there a workaround to remove these ugly sand colors?

@MillionsToOne
Copy link

Is there a workaround to remove these ugly sand colors?

Use the latest release or latest beta

@marek22k
Copy link

marek22k commented Oct 2, 2024

I use 6.904 from F-Droid. There doesn't seem a new version available.

@MillionsToOne
Copy link

I use 6.904 from F-Droid. There doesn't seem a new version available.

Use Github releases

@marek22k
Copy link

marek22k commented Oct 2, 2024

There is a possibility, but there is a reason why I use F-Droid and not GitHub releases. If you want to deliver updates faster in F-Droid, maybe use reproducible builds.

@MillionsToOne
Copy link

There is a possibility, but there is a reason why I use F-Droid and not GitHub releases. If you want to deliver updates faster in F-Droid, maybe use reproducible builds.

They're working on Thunderbird also.

@wmontwe
Copy link
Member

wmontwe commented Oct 16, 2024

This should be fixed with the latest Thunderbird Beta and K-9 Mail versions.

@wmontwe wmontwe closed this as completed Oct 16, 2024
@Akselmo
Copy link

Akselmo commented Oct 27, 2024

Any possibility for full-black background color? I find it very helpful on OLED screen because it helps with readability, i tend to need a very high contrast at times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tb-team Tasks and features handled by project maintainers type: bug Something is causing incorrect behavior or errors type: UI/UX Visual or UX design issues
Projects
None yet
Development

No branches or pull requests

9 participants