Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about test.h in CNN+ATT #36

Open
ShellingFord221 opened this issue Apr 18, 2020 · 2 comments
Open

about test.h in CNN+ATT #36

ShellingFord221 opened this issue Apr 18, 2020 · 2 comments

Comments

@ShellingFord221
Copy link

Hi, in /CNN+ATT/test.h, line 114, it seems that the function vector<double> test(int *sentence, int *testPositionE1, int *testPositionE2, int len, float *r) is never used, since vector<double> score is never used in the following codes.

Therefore, * r, which should represent sentence encoding in function vector<double> test(int *sentence, int *testPositionE1, int *testPositionE2, int len, float *r), now is a random vector in void* testMode(void *id ) and is then pushed into r_tmp.

Did I miss something? Thanks!

@JianJianHeng
Copy link

*r is not a random vector,it was computed on vector<double> test(...).And i also found vector<double> score is never used.

@revo1111
Copy link

revo1111 commented Aug 6, 2023

1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants