Skip to content
This repository has been archived by the owner on Apr 3, 2023. It is now read-only.

refactor: refine some msgs #370

Merged

Conversation

Rustin170506
Copy link
Contributor

@Rustin170506 Rustin170506 commented Jun 10, 2021

close #15

@todo
Copy link

todo bot commented Jun 10, 2021

add url.

// TODO: add url.
return `The \`${fileName}\` file must conform to the schema of the membership file.`;
}
export function contributorHasMultipleRoleWarning(githubName: string) {
return `${githubName} has multiple roles.`;


This comment was generated by todo based on a TODO comment in c4bc626 in #370. cc @hi-rustin.

@ti-chi-bot ti-chi-bot requested a review from Mini256 June 10, 2021 11:21
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2021
@Rustin170506
Copy link
Contributor Author

/hold

Integration testing is required.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #370 (c40fb96) into master (d2011fc) will increase coverage by 0.26%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
+ Coverage   74.91%   75.17%   +0.26%     
==========================================
  Files          25       25              
  Lines         574      564      -10     
  Branches       87       86       -1     
==========================================
- Hits          430      424       -6     
+ Misses        136      131       -5     
- Partials        8        9       +1     
Impacted Files Coverage Δ
src/services/sig/index.ts 96.55% <ø> (ø)
src/services/utils/SigInfoUtils.ts 100.00% <ø> (+4.34%) ⬆️
src/index.ts 71.73% <33.33%> (-1.60%) ⬇️
src/events/pull/index.ts 19.27% <50.00%> (+1.83%) ⬆️
src/services/messages/PullMessage.ts 100.00% <100.00%> (ø)
src/services/messages/SigMessage.ts 100.00% <100.00%> (ø)
src/services/pull/index.ts 100.00% <100.00%> (ø)
src/services/utils/ReplyUtil.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2011fc...c40fb96. Read the comment docs.

@Rustin170506
Copy link
Contributor Author

/unhold

Test it in ti-community-infra/test-dev#391 and ti-community-infra/test-dev#390

/assign @Mini256

PTAL~ Thanks!

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 10, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
src/events/pull/index.ts Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Mini256

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 11, 2021
@Mini256
Copy link
Member

Mini256 commented Jun 11, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c40fb96

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 11, 2021
@ti-chi-bot ti-chi-bot merged commit b0b7b9f into ti-community-infra:master Jun 11, 2021
@Rustin170506 Rustin170506 deleted the rustin-ptach-refactor-msg branch June 11, 2021 06:27
@Rustin170506
Copy link
Contributor Author

@Mini256 Thanks!

@rustin-bot
Copy link

🎉 This PR is included in version 1.9.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add url.
4 participants