Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update response model documentation to explain design choice #109

Merged
merged 2 commits into from
Mar 29, 2019

Conversation

JHSaunders
Copy link
Contributor

Closes #101

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         124    124           
  Lines        2987   2987           
=====================================
  Hits         2987   2987

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddb804...03edfd3. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 26, 2019

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         124    125    +1     
  Lines        2987   3007   +20     
=====================================
+ Hits         2987   3007   +20
Impacted Files Coverage Δ
tests/test_additional_properties.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ddb804...d677bd4. Read the comment docs.

@tiangolo tiangolo merged commit 714e68b into fastapi:master Mar 29, 2019
@tiangolo
Copy link
Member

Great! Thank you. I updated it a bit and merged. 🌮 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants