Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Spanish translation for docs/es/docs/fastapi-people.md #10910

Closed

Conversation

pablocm83
Copy link
Contributor

This is the Spanish translation for the people page.

Add Spanish translation for docs/es/docs/fastapi-people.md

  • Version >= 0.108.0

@tiangolo
Copy link
Member

tiangolo commented Jan 8, 2024

📝 Docs preview for commit 78fe7eb at: https://715730fe.fastapitiangolo.pages.dev

@JonanOribe
Copy link

Looks good to me (I'm a native Spanish speaker)

@alejsdev alejsdev changed the title This is the Spanish translation for the people page. 🌐 Add Spanish translation for docs/es/docs/fastapi-people.md Jan 9, 2024
@alejsdev alejsdev added lang-all Translations awaiting-review lang-de German translations lang-es Spanish translations and removed lang-de German translations labels Jan 9, 2024
@alejsdev
Copy link
Member

Hi, thanks for the help @pablocm83 🤓

I noticed that most of the internal links don't work because those files haven't been translated yet. There's a new section in Contributing that includes some tips for translation (https://fastapi.tiangolo.com/contributing/#translation-specific-tips-and-guidelines). I hope this helps. Thanks!

@tiangolo
Copy link
Member

📝 Docs preview for commit 3eb0426 at: https://aad0db50.fastapitiangolo.pages.dev

@pablocm83
Copy link
Contributor Author

@alejsdev internal links ready.

thanks

@tiangolo
Copy link
Member

📝 Docs preview for commit b4c8ba1 at: https://c9476a29.fastapitiangolo.pages.dev

@alejsdev
Copy link
Member

Hi @pablocm83

It was recently decided not to translate these pages. You can read more about this decision here: FastAPI Contributing.

We'll close this PR, but thank you for your effort! ✨

@alejsdev alejsdev closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-es Spanish translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants