Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2 typos in docs #1324

Merged
merged 1 commit into from
May 17, 2020
Merged

fix 2 typos in docs #1324

merged 1 commit into from
May 17, 2020

Conversation

waynerv
Copy link
Contributor

@waynerv waynerv commented Apr 25, 2020

Found some minor typos when translating the docs.

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #1324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1324   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          224       226    +2     
  Lines         6728      6785   +57     
=========================================
+ Hits          6728      6785   +57     
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
tests/test_skip_defaults.py 100.00% <0.00%> (ø)
tests/test_jsonable_encoder.py 100.00% <0.00%> (ø)
..._tutorial/test_sql_databases/test_sql_databases.py 100.00% <0.00%> (ø)
...est_sql_databases/test_sql_databases_middleware.py 100.00% <0.00%> (ø)
...test_application_configuration/test_tutorial001.py
...orial/test_sql_databases/test_testing_databases.py 100.00% <0.00%> (ø)
...ts/test_tutorial/test_metadata/test_tutorial001.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1cd45...bf3394b. Read the comment docs.

@tiangolo tiangolo merged commit cc3d795 into fastapi:master May 17, 2020
@tiangolo
Copy link
Member

Good catch, thanks a lot @waynerv ! 👏 🚀

🔍 🕵️ Good job detecting the:

Define a path operation function

That must have been confusing, especially more for newcomers. Thanks! ☕

@waynerv waynerv deleted the fix-typos-in-doc branch May 18, 2020 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants