Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention in docs that subapps don't fire events #1554

Merged
merged 2 commits into from
Jun 14, 2020
Merged

Mention in docs that subapps don't fire events #1554

merged 2 commits into from
Jun 14, 2020

Conversation

amacfie
Copy link
Contributor

@amacfie amacfie commented Jun 11, 2020

This should fix/related to #811

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #1554 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1554    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          230       236     +6     
  Lines         6862      7057   +195     
==========================================
+ Hits          6862      7057   +195     
Impacted Files Coverage Δ
tests/main.py 100.00% <0.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/docs.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
tests/test_application.py 100.00% <0.00%> (ø)
fastapi/security/__init__.py 100.00% <0.00%> (ø)
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 072c2bc...b6fe3e2. Read the comment docs.

@tiangolo tiangolo merged commit d63475b into fastapi:master Jun 14, 2020
@tiangolo
Copy link
Member

Nice! Thank you! 🍰 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants