Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Raise early when using form data without installing python-multipart #1851

Merged
merged 28 commits into from
Aug 8, 2020

Conversation

tiangolo
Copy link
Member

@tiangolo tiangolo commented Aug 8, 2020

✨ Raise early when using form data without installing the correct python-multipart.

This includes some updates on top of the work from #1627 by @YKo20010, @chrisngyn, @kx-chen.

YKo20010 and others added 27 commits June 25, 2020 15:11
* Add raising exceptions, update error messages
* Removed unused import, added comments

Co-authored-by: Christopher Nguyen <chrisngyn99@gmail.com>
Adds annotations to is_form_data

* Fix import order
Remove error spaces when printing

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #1851 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1851   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          236       236           
  Lines         7068      7073    +5     
=========================================
+ Hits          7068      7073    +5     
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <100.00%> (ø)
tests/test_multipart_installation.py 100.00% <100.00%> (ø)
fastapi/params.py 100.00% <0.00%> (ø)
fastapi/routing.py 100.00% <0.00%> (ø)
fastapi/encoders.py 100.00% <0.00%> (ø)
fastapi/exceptions.py 100.00% <0.00%> (ø)
fastapi/applications.py 100.00% <0.00%> (ø)
fastapi/openapi/utils.py 100.00% <0.00%> (ø)
fastapi/security/http.py 100.00% <0.00%> (ø)
tests/test_param_class.py 100.00% <0.00%> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b87072b...0cf5b4e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2020

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2020

📝 Docs preview for commit 0cf5b4e at: https://5f2e4ff3bf54e99c8e7196a5--fastapi.netlify.app

@tiangolo tiangolo merged commit 38d8bab into master Aug 8, 2020
@tiangolo tiangolo deleted the raise-form-early-2 branch August 8, 2020 07:14
@tiangolo tiangolo mentioned this pull request Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants