-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add japanese translation for deployment.md #1948
Add japanese translation for deployment.md #1948
Conversation
…/ryuckel/fastapi into feature/add-japanese-translation
…/tokusumi/fastapi into translation/add-japanese-deployment
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 239 239
Lines 7079 7079
=========================================
Hits 7079 7079 Continue to review full report at Codecov.
|
📝 Docs preview for commit 3eb7eff at: https://5f409afb05ebe942f6ed86f5--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for translating a very difficult chapter.
I was concerned about some minor wording, so if you can fix that, it's not a problem.
docs/ja/docs/deployment.md
Outdated
|
||
高頻度で新機能が追加され、定期的にバグが修正され、実装は継続的に改善されています。 | ||
|
||
これが現在のバージョンがいまだに `0.x.x` な理由であり、それぞれのバージョンは破壊的な変更がなされる可能性があります。<a href="https://semver.org/" class="external-link" target="_blank">Semantic Versioning</a>の規則に則っています。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Japanese version of this URL reference uses katakana, so you may as well write it in katakana. ("Semantic Version")
docs/ja/docs/deployment.md
Outdated
|
||
アプリケーションにテストを加えるべきです。 | ||
|
||
**FastAPI** では非常に簡単に実現できます (Starletteのおかげで)。ドキュメントを確認して下さい: [Testing](tutorial/testing.md){.internal-link target=_blank} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing -> テスト
docs/ja/docs/deployment.md
Outdated
|
||
#### Raspberry Piなどのアーキテクチャ | ||
|
||
Raspberry Pi (ARMプロセッサ搭載)やそれ以外のアーキテクチャでDockerが作動している場合、(マルチアーキテクチャである) Pythonベースイメージを使って一から`Dockerfile`を作成し、Uvicornを使用できます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raspberry Pi (ARMプロセッサ搭載)やそれ以外のアーキテクチャでDockerが作動している場合、(マルチアーキテクチャである) Pythonベースイメージを使って、一からDockerfile
を作成し、Uvicornを使用できます。
It might be easier to read with punctuation.
docs/ja/docs/deployment.md
Outdated
|
||
</div> | ||
|
||
ここで、Dockerコンテナ内に最適化されたFastAPIサーバが動作しています。使用しているサーバ (そしてCPUコア数) に沿った自動チューニングが行われています。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これで、Docker~
docs/ja/docs/deployment.md
Outdated
|
||
### 確認 | ||
|
||
DockerコンテナのURLで確認すべきです。例えば: <a href="http://192.168.99.100/items/5?q=somequery" class="external-link" target="_blank">http://192.168.99.100/items/5?q=somequery</a> や <a href="http://127.0.0.1/items/5?q=somequery" class="external-link" target="_blank">http://127.0.0.1/items/5?q=somequery</a> (もしくはDockerホストを使用したこれらと同等のもの)。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DockerコンテナのURLで確認できるはずです。
docs/ja/docs/deployment.md
Outdated
|
||
2分程度でプロジェクトが生成されます。 | ||
|
||
生成されたプロジェクトはデプロイするための説明がありますが、それにはさらに2分かかります。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
生成sれたプロジェクトにはデプロイの指示がありますが、それを実行するとさらに2分かかります。
docs/ja/docs/deployment.md
Outdated
|
||
ワーカー数などの微調整も行いたいかもしれません。 | ||
|
||
しかしこれら全てをやろうとすると、自動的にこれらを行うDockerイメージを使うことになってしまうかも知れません。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
しかしこれら全てをやろうとすると、自動的にこれらを行うDockerイメージを使えばよいだけかもしれません。
@SwftAlpc |
📝 Docs preview for commit 07fb1c7 at: https://5f47cd4351506c5876cd32cc--fastapi.netlify.app |
…nslation/add-japanese-deployment
📝 Docs preview for commit 85dc0ff at: https://5f4a706acedffd40fc61a910--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate for your nice translate. 👍
I commented to more improve your translate.
Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>
@komtaki |
📝 Docs preview for commit daa84b1 at: https://5f6e08f9c0129410a8bd06e1--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙆♂️
📝 Docs preview for commit 6f0d712 at: https://5f9af23c61873e1c6f88074e--fastapi.netlify.app |
This section is separated into some sections in the latest docs. |
This PR translates the deployment.md to Japanese.
Please review deployment.md
Issue #1571 generates a new directory to support Japanese.I will fix dependency after #1571 is merged.