Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/sub-dependencies.md #1959

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/dependencies/sub-dependencies.md to Japanese.
Please review tutorial/dependencies/sub-dependencies.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.

PR #1957 generates a new directoru for dependencies in tutorial.
I will fix dependency after #1571, #1656 and #1957 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (4da100a) 100.00%.
Report is 1066 commits behind head on master.

❗ Current head 4da100a differs from pull request most recent head 21ee8ec. Consider uploading reports for the commit 21ee8ec to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1959     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit b9ae6e6 at: https://5f4286ff442f8ec97dc9c37a--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
SwftAlpc and others added 3 commits October 30, 2020 01:02
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for your reveiw!!
Please check it out.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4da100a at: https://5f9ae876e1fb9b0d5df2ff94--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work!

@tiangolo tiangolo changed the title Add tutorial/dependencies/sub-dependencies.md Japanese ver 🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/index.md and docs/ja/docs/tutorial/dependencies/sub-dependencies.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit 734d902 at: https://6499c4ed4a9646007dd7a740--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/index.md and docs/ja/docs/tutorial/dependencies/sub-dependencies.md 🌐 Add Japanese translation for docs/ja/docs/tutorial/dependencies/sub-dependencies.md Jan 15, 2024
@tiangolo
Copy link
Member

As this was made by @SwftAlpc and approved by @tokusumi, champions of the Japanese translations, I'm gonna merge this right away. 🚀 Thank you! ☕

@tiangolo tiangolo enabled auto-merge (squash) January 15, 2024 16:24
@tiangolo tiangolo merged commit c68836a into fastapi:master Jan 15, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants