Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for Advanced - Path Operation Advanced Configuration #2124

Conversation

Attsun1031
Copy link
Contributor

This PR translates the advanced/path-operation-advanced-configuration.md to Japanese.
Please review advanced/path-operation-advanced-configuration.md and ja/mkdocs.yml.

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #2124 (3066853) into master (54eeb31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2124   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2eb4a7...3066853. Read the comment docs.

@Attsun1031 Attsun1031 mentioned this pull request Oct 3, 2020
@Attsun1031 Attsun1031 force-pushed the translation/add-japanese-doc-advance-path-ops branch from ae494ca to c6ecd33 Compare October 3, 2020 07:43
@Attsun1031 Attsun1031 force-pushed the translation/add-japanese-doc-advance-path-ops branch from c6ecd33 to 69a62ab Compare October 3, 2020 07:45
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2020

📝 Docs preview for commit 69a62ab at: https://5f7832c683304ee2b4f88cd7--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for great work. I commented some feedback.

Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@Attsun1031
Copy link
Contributor Author

@tokusumi Thank you for your nice suggestions ! I've fix everything, so please check again.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2020

📝 Docs preview for commit 3f5463a at: https://5f79845cc2c10c910d740a16--fastapi.netlify.app

@Attsun1031
Copy link
Contributor Author

I resolved all conflicts (All were mkdocs nav order)
e381456

@github-actions
Copy link
Contributor

📝 Docs preview for commit e381456 at: https://5f8bf9e12ff9408589abed7c--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late response.
great work!

@tokusumi
Copy link
Contributor

@tiangolo, This PR is Japanese tlanslation. could you add some labels?

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Nov 5, 2020
Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good.
I pointed out some details.

!!! warning "注意"
あなたがOpenAPIの「エキスパート」でなければ、これは必要ないかもしれません。

*path operation* で `operationId` パラメータを利用することで、OpenAPIの `operationId` を設定できます。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First "operationId" should be "operation_id" because its's Python's arg name.


*path operation* で `operationId` パラメータを利用することで、OpenAPIの `operationId` を設定できます。

各オペレーションで一意にする必要があります。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, Its' a little better to add "operationIdは" before "各オペレーションで" because I feel the subject of the sentence is a little difficult to understand.

@Attsun1031
Copy link
Contributor Author

@delhi09 Thank you for your nice suggestions ! I've fix everything, so please check again.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2021

📝 Docs preview for commit 3066853 at: https://5ff7c1601449a800901f78cd--fastapi.netlify.app

Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo tiangolo changed the title Add advanced/path-operation-advanced-configuration.md Japanese ver. 🌐 Add Japanese translation for Advanced - Path Operation Advanced Configuration Jan 9, 2021
@tiangolo
Copy link
Member

tiangolo commented Jan 9, 2021

Great! Thanks @Attsun1031 ! 🙇 🚀

And thanks @tokusumi and @delhi09 for the reviews 🔍 🍰

@tiangolo tiangolo merged commit 5a4a61c into fastapi:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants