Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for Advanced - Custom Response #2193

Merged
merged 4 commits into from
Nov 25, 2020
Merged

🌐 Add Japanese translation for Advanced - Custom Response #2193

merged 4 commits into from
Nov 25, 2020
+224 −0

Conversation

Attsun1031
Copy link
Contributor

This PR translates the advanced/custom-response.md to Japanese.

@Attsun1031 Attsun1031 mentioned this pull request Oct 18, 2020
Closed
@codecov
Copy link

codecov bot commented Oct 18, 2020 •
edited
Loading

Codecov Report

Merging #2193 (6126d3a) into master (2434980) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2193   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2434980...6126d3a. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 44b4f1c at: https://5f8bf9da084e2fd1b9a83340--fastapi.netlify.app

tokusumi
tokusumi suggested changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for translation!

docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
@Attsun1031 @tokusumi
Apply suggestions from code review
132be7d 
Co-authored-by: T. Tokusumi <41147016+tokusumi@users.noreply.github.com>
@Attsun1031
Copy link
Contributor Author

@tokusumi Thank you for your careful review ! I fixed everything, so please review again.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 132be7d at: https://5f9b6c469169392998f96af3--fastapi.netlify.app

tokusumi
tokusumi approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update!

komtaki
komtaki reviewed Nov 3, 2020
View reviewed changes
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your tough work. 👏

I suggested a few change to improve.

docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
docs/ja/docs/advanced/custom-response.md Outdated Show resolved Hide resolved
@Attsun1031 @komtaki
Apply suggestions from code review
a65edcc 
Co-authored-by: Taki Komiyama <39375566+komtaki@users.noreply.github.com>
@Attsun1031
Copy link
Contributor Author

@komtaki Thank you for your careful review ! I fixed everything, so please check again.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2020

📝 Docs preview for commit a65edcc at: https://5fa217cb0cbb703bbaed43f9--fastapi.netlify.app

komtaki
komtaki approved these changes Nov 4, 2020
View reviewed changes
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for update 👍

@tiangolo tiangolo changed the title Add Japanese translation for Advanced - custom-response 🌐 Add Japanese translation for Advanced - Custom Response Nov 25, 2020
@tiangolo
Copy link
Member

Awesome! Thanks @Attsun1031 🙇 🚀

And thank you @komtaki and @tokusumi for the reviews 🤓 ☕

@github-actions
Copy link
Contributor

📝 Docs preview for commit 6126d3a at: https://5fbe96df544f3c0ea1004569--fastapi.netlify.app

@tiangolo tiangolo merged commit cc99e23 into fastapi:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokusumi tokusumi tokusumi approved these changes

@komtaki komtaki komtaki approved these changes

Assignees
No one assigned
Labels
approved-2 hacktoberfest-accepted lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Attsun1031 @tiangolo @komtaki @tokusumi