Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for Deployment - Manually #2313

Merged

Conversation

tokusumi
Copy link
Contributor

@tokusumi tokusumi commented Nov 6, 2020

This PR translates deployment/manually.md in Japanese.

To all reviewers. This section is only separated from #1948 (with few changes), but please review it.

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2313 (cb0dd2a) into master (c7742e3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          243       243           
  Lines         7419      7419           
=========================================
  Hits          7419      7419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05b024d...cb0dd2a. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2020

📝 Docs preview for commit 9825cb8 at: https://5fa535a26148c3ff33a73210--fastapi.netlify.app

@tokusumi tokusumi mentioned this pull request Nov 6, 2020
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Nov 7, 2020
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tough work.
LGTM 👍

Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good.
But the translation of the one "Tip" section seems to be missing.

---> 100%
```

</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the translation of the following sentences is missing.

Tip
By adding the standard, Uvicorn will install and use some recommended extra dependencies.
That including uvloop, the high-performance drop-in replacement for asyncio, that provides the big concurrency performance boost.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 94cd37a at: https://5fec825a8d5b5e52728be9b1--fastapi.netlify.app

@tokusumi
Copy link
Contributor Author

@delhi09 Thank you for review!
I updated translation. please check it again.

Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiangolo
Copy link
Member

tiangolo commented Jan 9, 2021

Thank you very much for updating all this @tokusumi 🙇 🍰

And as always, thanks @komtaki and @delhi09 for the reviews 🔍 ☕

@tiangolo tiangolo merged commit 2b49b8c into fastapi:master Jan 9, 2021
@tokusumi tokusumi deleted the translation/add-ja-deployment-manually branch January 10, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants