-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for Deployment - Manually #2313
🌐 Add Japanese translation for Deployment - Manually #2313
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2313 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 243 243
Lines 7419 7419
=========================================
Hits 7419 7419 Continue to review full report at Codecov.
|
📝 Docs preview for commit 9825cb8 at: https://5fa535a26148c3ff33a73210--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the tough work.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks mostly good.
But the translation of the one "Tip" section seems to be missing.
---> 100% | ||
``` | ||
|
||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the translation of the following sentences is missing.
Tip
By adding the standard, Uvicorn will install and use some recommended extra dependencies.
That including uvloop, the high-performance drop-in replacement for asyncio, that provides the big concurrency performance boost.
📝 Docs preview for commit 94cd37a at: https://5fec825a8d5b5e52728be9b1--fastapi.netlify.app |
@delhi09 Thank you for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR translates deployment/manually.md in Japanese.
To all reviewers. This section is only separated from #1948 (with few changes), but please review it.