Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Fix highlight lines for Japanese translation for docs/tutorial/query-params.md #2969

Merged

Conversation

ftnext
Copy link
Contributor

@ftnext ftnext commented Mar 21, 2021

Fix #2966

Example: fix https://fastapi.tiangolo.com/ja/tutorial/query-params/#_3
fix-query-params-tutorial1

P.S.
I found another mismatches of highlight lines, so open another issues and pull requests.

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 230e7a9 at: https://6056e2dcd60627b6ec389c09--fastapi.netlify.app

@tiangolo tiangolo changed the title [Translation ja] Fix highlight lines in Query Parameters tutorial 馃寪 Fix highlight lines for Japanese translation for docs/tutorial/query-params.md Jul 21, 2021
@tiangolo tiangolo added awaiting review lang-all Translations lang-ja Japanese translations labels Jul 21, 2021
Copy link
Contributor

@komtaki komtaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憦

@github-actions
Copy link
Contributor

馃摑 Docs preview for commit 2da290e at: https://6370f757a1be044e67671806--fastapi.netlify.app

@tiangolo
Copy link
Owner

Awesome, thanks! @ftnext! 馃嵃

And thanks for the reviews @wakabame and @komtaki 馃檱

@tiangolo tiangolo merged commit 0781a91 into tiangolo:master Nov 13, 2022
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Japanese translation problem: highlighted lines mismatch with English ver.
4 participants