Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Only trigger build-docs CI in case of doc updates #3033

Closed
wants to merge 2 commits into from

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Apr 1, 2021

😗

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #3033 (0036c0f) into master (0ceacef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #3033   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          409       409           
  Lines        10264     10264           
=========================================
  Hits         10264     10264           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ceacef...0036c0f. Read the comment docs.

@tiangolo tiangolo changed the title 👷 Only trigger build-docs in case of doc updates 👷 Only trigger build-docs CI in case of doc updates Oct 7, 2021
@tiangolo
Copy link
Member

tiangolo commented Oct 7, 2021

Oh, nice! 😎 🎉

Thanks @Kludex! 🍰

@tiangolo
Copy link
Member

tiangolo commented Oct 7, 2021

Dang it, I really liked the idea. But now GitHub is stuck waiting for the "Expected" build-docs workflow... and if I remove it from the expected checks, then I wouldn't be able to auto-merge other PRs once checks are passing, because it would merge with just the tests, even if docs are broken. 😔

So for now I'll have to leave it as it is and pass on this PR. 😔 But thanks for the effort! ☕

@tiangolo tiangolo closed this Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants