Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastapi.middleware.sessions #3322

Closed
wants to merge 2 commits into from
Closed

Add fastapi.middleware.sessions #3322

wants to merge 2 commits into from

Conversation

br-kim
Copy link

@br-kim br-kim commented Jun 2, 2021

get SessionMiddleware from starlette.middleware.sessions for convenience.

I'm learning python web framework using fastapi.
Thank you for providing a good Framework and Docs.

I'm adding it because I think it's missing.
It's simple, but I haven't done much pull request, so I'd appreciate it if you could check if it's the right pull request.

get SessionMiddleware from starlette.middleware.sessions for convenience
@br-kim br-kim closed this Jun 2, 2021
@br-kim br-kim reopened this Jun 2, 2021
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #3322 (1058614) into master (b2aa359) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##            master    #3322      +/-   ##
===========================================
- Coverage   100.00%   99.99%   -0.01%     
===========================================
  Files          540      541       +1     
  Lines        13951    13952       +1     
===========================================
  Hits         13951    13951              
- Misses           0        1       +1     
Impacted Files Coverage Δ
fastapi/middleware/sessions.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 1058614 at: https://631e1276ce733f48f266dc23--fastapi.netlify.app

@tiangolo
Copy link
Member

Thanks for the interest! But the best way to handle sessions in FastAPI would be with dependencies and the security/auth utilities, so I'll pass on this one, but thanks! ☕

@tiangolo tiangolo closed this Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants