Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆ Upgrade Swagger UI copy of oauth2-redirect.html to include fixes for flavors of authorization code flows in Swagger UI #3439

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

koonpeng
Copy link
Contributor

@koonpeng koonpeng commented Jul 1, 2021

When trying to log in with the authorization code flow with oidc, some IdP may result in the error

Auth ErrorError, error: invalid_request, description: Missing parameter: code

This is caused by a swagger ui bug swagger-api/swagger-ui#6741. The bug has been fixed but fastapi has an old version of oauth2-redirect.html embedded into it.

This PR simply updates that to the latest release version.

@tiangolo tiangolo changed the title fix authorization code flow not working in builtin swagger ui docs ⬆ Upgrade Swagger UI copy of oauth2-redirect.html to include fixes for flavors of authorization code flows in Swagger UI Aug 23, 2022
@tiangolo
Copy link
Member

Thanks for your contribution @koonpeng! 🙇 🚀

And thanks @Mause for the review. 🍪

@tiangolo tiangolo enabled auto-merge (squash) August 23, 2022 13:56
@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #3439 (afe7abd) into master (09acce4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #3439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          533       533           
  Lines        13755     13755           
=========================================
  Hits         13755     13755           
Impacted Files Coverage Δ
fastapi/openapi/docs.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tiangolo tiangolo merged commit ec072d7 into fastapi:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants