-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Korean translation for docs/ko/docs/tutorial/path-operation-configuration.md
#3639
Conversation
docs/tutorial/path-operation-configuration.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome aboard and nice work🎉 Please check my reviews.
|
||
각 상태 코드들은 응답에 사용되며, OpenAPI 스키마에 추가됩니다. | ||
|
||
!!! note "기술적 디테일" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!! note "기술적 디테일" | |
!!! note "기술 세부사항" |
It is better to use the same term.
|
||
## Tags | ||
|
||
*경로 동작*에 태그를 달수도 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한개의 `str`으로 이루어져 있습니다.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*경로 동작*에 태그를 달수도 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한개의 `str`으로 이루어져 있습니다.) | |
*경로 동작*에 태그를 달 수 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한 개의 `str`으로 이루어져 있습니다): |
`response_description` 매개변수로 응답 기술을 명시할수 있습니다. | ||
You can specify the response description with the parameter `response_description`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`response_description` 매개변수로 응답 기술을 명시할수 있습니다. | |
You can specify the response description with the parameter `response_description`: | |
`response_description` 매개변수로 응답 기술을 명시할 수 있습니다: |
|
||
## 독스트링으로 만든 기술 | ||
|
||
기술이 보통 길고 여러줄에 걸쳐있기 때문에, *경로 동작* 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에 선언할수 있습니다, 이를 **FastAPI**가 독스트링으로부터 읽습니다. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기술이 보통 길고 여러줄에 걸쳐있기 때문에, *경로 동작* 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에 선언할수 있습니다, 이를 **FastAPI**가 독스트링으로부터 읽습니다. | |
설명은 보통 길어지고 여러 줄에 걸쳐있기 때문에, *경로 동작* 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열�"> 독스트링</abbr> 에 선언할 수 있습니다, 이를 **FastAPI**가 독스트링으로부터 읽습니다. |
I think 설명
is better than 기술
because the latter one confuses "description" with "technique"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big appreciate of your works and great honor to check it 🚀
Please feel free to check my reviews and update (fetch) the file to latest version.
Also, please add a file path to mkdocs.yml
!
applied suggestion from @0417taehyun thank you for correction Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
pulled latest updates in fastapi
@hard-coders @0417taehyun added revision to pr thank you for all the suggestions could you please review again to finalize pr? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort! I reviewd some typos
applied review regarding style and typos Co-authored-by: Spike <rurouni24@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@hard-coders Do I need to do anything additional to finalize the merge? |
No, you don't need to. Please wait for the other reviewer and maintainer's approval. |
@hard-coders thx |
docs/tutorial/path-operation-configuration.md
docs/ko/docs/tutorial/path-operation-configuration.md
📝 Docs preview for commit d63019c at: https://6499e2d558574906037570d3--fastapi.netlify.app |
Thanks for your work! @jungsu-kwon 🤓 And thanks for the review @hard-coders 🚀 |
hello I have added korean translation for
path-operation-configuration.md
thank you for reviews in prior
related #2017