Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for docs/ko/docs/tutorial/path-operation-configuration.md #3639

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

jungsu-kwon
Copy link
Contributor

hello I have added korean translation for

path-operation-configuration.md

thank you for reviews in prior

related #2017

@tiangolo tiangolo changed the title 🌐 Add Korean translation for Tutorial - Path Operation Configuration.md 🌐 Add Korean translation for docs/tutorial/path-operation-configuration.md Aug 18, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-ko Korean translations labels Aug 18, 2021
@github-actions github-actions bot mentioned this pull request Aug 18, 2021
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome aboard and nice work🎉 Please check my reviews.


각 상태 코드들은 응답에 사용되며, OpenAPI 스키마에 추가됩니다.

!!! note "기술적 디테일"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!!! note "기술적 디테일"
!!! note "기술 세부사항"

It is better to use the same term.


## Tags

*경로 동작*에 태그를 달수도 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한개의 `str`으로 이루어져 있습니다.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*경로 동작*에 태그를 달수도 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한개의 `str`으로 이루어져 있습니다.)
*경로 동작*에 태그를 달 수 있습니다, `tags` 매개변수를 `str`으로 이루어진 `list`의 형태로 전달하시면 됩니다 (보통은 한 개의 `str`으로 이루어져 있습니다):

Comment on lines 63 to 64
`response_description` 매개변수로 응답 기술을 명시할수 있습니다.
You can specify the response description with the parameter `response_description`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`response_description` 매개변수로 응답 기술을 명시할수 있습니다.
You can specify the response description with the parameter `response_description`:
`response_description` 매개변수로 응답 기술을 명시할 수 있습니다:


## 독스트링으로 만든 기술

기술이 보통 길고 여러줄에 걸쳐있기 때문에, *경로 동작* 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에 선언할수 있습니다, 이를 **FastAPI**가 독스트링으로부터 읽습니다.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
기술이 보통 길고 여러줄에 걸쳐있기 때문에, *경로 동작* 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에 선언할수 있습니다, 이를 **FastAPI**가 독스트링으로부터 읽습니다.
설명은 보통 길어지고 여러 줄에 걸쳐있기 때문에, *경로 동작* 기술을 함수 <abbr title="함수안에 있는 첫번째 표현식으로, 문서로 사용될 여러 줄에 걸친 (변수에 할당되지 않은) 문자열"> 독스트링</abbr> 에 선언할 수 있습니다, 이를 **FastAPI**가 독스트링으로부터 읽습니다.

I think 설명 is better than 기술 because the latter one confuses "description" with "technique"

Copy link
Contributor

@0417taehyun 0417taehyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big appreciate of your works and great honor to check it 🚀

Please feel free to check my reviews and update (fetch) the file to latest version.

Also, please add a file path to mkdocs.yml !

docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
jungsu-kwon and others added 4 commits November 21, 2021 10:26
applied suggestion from @0417taehyun

thank you for correction

Co-authored-by: weekwith.me <63915557+0417taehyun@users.noreply.github.com>
@jungsu-kwon
Copy link
Contributor Author

@hard-coders @0417taehyun added revision to pr

thank you for all the suggestions

could you please review again to finalize pr?

Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort! I reviewd some typos

docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/path-operation-configuration.md Outdated Show resolved Hide resolved
applied review regarding style and typos

Co-authored-by: Spike <rurouni24@gmail.com>
Copy link
Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jungsu-kwon
Copy link
Contributor Author

@hard-coders Do I need to do anything additional to finalize the merge?

@hard-coders
Copy link
Contributor

@hard-coders Do I need to do anything additional to finalize the merge?

No, you don't need to. Please wait for the other reviewer and maintainer's approval.

@jungsu-kwon
Copy link
Contributor Author

@hard-coders thx

joonas-yoon added a commit to joonas-yoon/fastapi that referenced this pull request Aug 6, 2022
@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/tutorial/path-operation-configuration.md 🌐 Add Korean translation for docs/ko/docs/tutorial/path-operation-configuration.md Jun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit d63019c at: https://6499e2d558574906037570d3--fastapi.netlify.app

@alejsdev alejsdev merged commit 66ef70a into fastapi:master Jan 22, 2024
2 checks passed
@alejsdev
Copy link
Member

Thanks for your work! @jungsu-kwon 🤓

And thanks for the review @hard-coders 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants