Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Add external link to article: Deploying ML Models as API Using FastAPI and Heroku #3904

Merged
merged 9 commits into from
Oct 7, 2021
Merged

📝 Add external link to article: Deploying ML Models as API Using FastAPI and Heroku #3904

merged 9 commits into from
Oct 7, 2021

Conversation

kaustubhgupta
Copy link
Contributor

@kaustubhgupta kaustubhgupta commented Sep 15, 2021 •
edited
Loading

📝 Update external_links.yml : Added english Blog link

ArcLightSlavik
ArcLightSlavik suggested changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@ArcLightSlavik ArcLightSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unwritten rule: new articles should be added in the end of the list not the start

@kaustubhgupta
Copy link
Contributor Author

@ArcLightSlavik Done

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit ad059c4 at: https://615f10c6b8fcb435e50bda64--fastapi.netlify.app

@tiangolo tiangolo changed the title 📝 Update external_links.yml : Added english Blog link 📝 Add external link to article: Deploying ML Models as API Using FastAPI and Heroku Oct 7, 2021
@tiangolo
Copy link
Member

tiangolo commented Oct 7, 2021

Thanks @kaustubhgupta! 📝

And thanks for the help @ArcLightSlavik! 🍰

I recently re-ordered the links to have the most recent on top, so I just re-ordered this one as well.

@tiangolo tiangolo enabled auto-merge (squash) October 7, 2021 15:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit bd15ea0 at: https://615f119af7bbc03960987208--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit c96f280 at: https://615f1337606f2837532c21af--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit 8b8a7ea at: https://615f155153eb8b3f68f29db8--fastapi.netlify.app

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2021

📝 Docs preview for commit 43bdc71 at: https://615f16d4b8fcb439770bd68d--fastapi.netlify.app

@tiangolo tiangolo disabled auto-merge October 7, 2021 15:55
@tiangolo tiangolo merged commit 9c6e0d0 into fastapi:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArcLightSlavik ArcLightSlavik ArcLightSlavik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaustubhgupta @tiangolo @ArcLightSlavik