Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Update German translation for docs/features.md #3905

Merged
merged 4 commits into from
May 9, 2022

Conversation

jomue
Copy link
Contributor

@jomue jomue commented Sep 15, 2021

I've fixed a few typos in the german translation.

* Unterstütz komplexe Benutzerauthentifizierungssysteme, mit **Datenbankverbindungen**, usw.
* **Keine Kompromisse** bei Datenbanken, Eingabemasken, usw. Sondern einfache Integration von allen.
* Unterstützt komplexe Benutzerauthentifizierungssysteme, mit **Datenbankverbindungen**, usw.
* **Keine Kompromisse** bei Datenbanken, Eingabemasken, usw. sondern einfache Integration von allen.
Copy link
Contributor

@mawassk mawassk Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comma after usw., otherwise it´s look good.

  • Keine Kompromisse bei Datenbanken, Eingabemasken, usw., sondern einfache Integration von allen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ArcLightSlavik
Copy link
Contributor

Could you update the name of PR to Update German Translation for docs/features.md

@jomue jomue changed the title Improve german translation Update German Translation for docs/features.md Sep 22, 2021
@tiangolo tiangolo changed the title Update German Translation for docs/features.md 🌐 Update German translation for docs/features.md Oct 5, 2021
@tiangolo tiangolo added awaiting-review lang-all Translations lang-de German translations labels Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3905 (6fcf259) into master (ee4e27a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #3905   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13629     13629           
=========================================
  Hits         13629     13629           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4e27a...6fcf259. Read the comment docs.

@github-actions github-actions bot mentioned this pull request Oct 5, 2021
Copy link

@rogerbrinkmann rogerbrinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposed changes are necessary and correct

Copy link

@jsbeckr jsbeckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes typos and mistranslation 👍

@tiangolo
Copy link
Member

tiangolo commented May 9, 2022

Awesome, thank you @jomue! 🙇

And thanks for the reviews @jsbeckr, @rogerbrinkmann, @mawassk! 🍰

And thanks for the help @ArcLightSlavik! 😎

@tiangolo tiangolo merged commit 1234288 into fastapi:master May 9, 2022
@jomue jomue deleted the patch-1 branch May 13, 2022 09:34
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-2 lang-all Translations lang-de German translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants