Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add French translation for docs/fr/docs/tutorial/query-params-str-validations.md #4075

Conversation

Smlep
Copy link
Contributor

@Smlep Smlep commented Oct 20, 2021

Hey everyone! 👋

Here is the PR to translate the query params and string validations page of the tutorial documentation into french.
See the french translation tracking issue here.

Thanks for the reviews👌

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (cb64168) 100.00%.

❗ Current head cb64168 differs from pull request most recent head b93bee0. Consider uploading reports for the commit b93bee0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4075   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13946   -23     
=========================================
- Hits         13969     13946   -23     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 431210a at: https://61707946a55758161189f1fc--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit b579514 at: https://61707eb414183214efd25a85--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 4dcf89d at: https://6170827f1418321f86d25772--fastapi.netlify.app

Copy link
Contributor

@JulianMaurin JulianMaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Smlep !
Well done and thanks a lot for the work 💪

I did many suggestions but some are more important than others, feel free to decline if you think that is not a good move. For example, I think that we have to avoid using the third person of singular (on) in favour of a formal nous ou vous.

The main issue is that we are missing two recent chapters.

Keep me in touch for the second round 🚀

docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
La documentation l'affichera bien comme déprécié (`deprecated`) :

<img src="/img/tutorial/query-params-str-validations/image01.png">

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing section Exclude from OpenAPI
see

docs/fr/docs/tutorial/query-params-str-validations.md Outdated Show resolved Hide resolved
Smlep and others added 16 commits October 22, 2022 22:16
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Smlep and others added 13 commits October 22, 2022 22:26
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
@github-actions
Copy link
Contributor

📝 Docs preview for commit cb64168 at: https://635454d76f3b9662f3cc0105--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 9dcbd80 at: https://639cc8dc3508160d2b0a8f10--fastapi.netlify.app

@tiangolo tiangolo changed the title 🌐 Add French translation for docs/tutorial/query-params-str-validations.md 🌐 Add French translation for docs/fr/docs/tutorial/query-params-str-validations.md Jun 26, 2023
@tiangolo
Copy link
Member

📝 Docs preview for commit b93bee0 at: https://649a0f71acd72b0d3761e966--fastapi.netlify.app

@tiangolo
Copy link
Member

Thank you @Smlep! 🍰

And thanks for the reviews @JulianMaurin, @axel584, @krocdort 💃

@tiangolo tiangolo merged commit 04b9a67 into fastapi:master Jul 27, 2023
erosennin pushed a commit to erosennin/fastapi that referenced this pull request Jul 31, 2023
…validations.md` (fastapi#4075)

Co-authored-by: Julian Maurin <julian.maurin.perso@pm.me>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants