⬆ Upgrade Starlette from 0.17.1 to 0.18.0 #4483

Kludex · 2022-01-26T16:25:58Z

For reference, set of changes that broke FastAPI:

Update type annotations for BackgroundTask and utils encode/starlette#1383 (mypy)
Don't set headers for responses with 1xx, 204 and 304 status code encode/starlette#1397
Don't omit Content-Length header for Content-Length: 0 cases encode/starlette#1395

Related to #4477

codecov · 2022-01-26T16:28:29Z

Codecov Report

Merging #4483 (25feb07) into master (146f57b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #4483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          531       531           
  Lines        13627     13630    +3     
=========================================
+ Hits         13627     13630    +3

Impacted Files	Coverage Δ
fastapi/concurrency.py	`100.00% <100.00%> (ø)`
fastapi/dependencies/utils.py	`100.00% <100.00%> (ø)`
fastapi/routing.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 146f57b...25feb07. Read the comment docs.

github-actions · 2022-01-26T16:31:09Z

📝 Docs preview for commit e5c9343 at: https://61f176cddc1930f5b39fe9cd--fastapi.netlify.app

Kludex · 2022-01-26T16:33:20Z

fastapi/dependencies/utils.py

+    if response is None:
+        response = Response()
+        del response.headers["content-length"]
+        response.status_code = None


@tomchristie FastAPI uses a Response object that travels through the dependencies, but that Response is not the response that will be returned at the end. There's a "cleanup" after the dependencies are solved. You can see the "cleanup" logic below:

https://github.com/tiangolo/fastapi/blob/291180bf2d8c39e84860c2426b1d58b6c80f6fef/fastapi/routing.py#L216-L254

I've selected the whole snippet, from the point we get the Response object used in the dependencies (solve_dependencies call) until the last 5 lines (on which the values from Response are passed to the actual response object that will be used.

This comment is JFYK, I don't expect any action to be taken on Starlette. Also, considering that FastAPI tweaks Starlette internally for some features it has.

github-actions · 2022-01-26T16:38:12Z

📝 Docs preview for commit 8d10fca at: https://61f178c33b56fbf00cd761e2--fastapi.netlify.app

Kludex · 2022-01-26T16:49:49Z

fastapi/routing.py

@@ -126,7 +126,7 @@ async def serialize_response(
        if is_coroutine:
            value, errors_ = field.validate(response_content, {}, loc=("response",))
        else:
-            value, errors_ = await run_in_threadpool(
+            value, errors_ = await run_in_threadpool(  # type: ignore[misc]


We added ParamSpec to run_in_threadpool on Starlette. The error here was:

fastapi/routing.py:129: error: "<nothing>" object is not iterable [misc]

github-actions · 2022-01-26T16:53:18Z

📝 Docs preview for commit fb2fdf5 at: https://61f17c4d603b5ade0e34ca0d--fastapi.netlify.app

yezz123

@Kludex 🌟

L1ghtn1ng · 2022-03-02T01:24:33Z

can this get merged soon and released please?

ShadowLNC · 2022-03-14T04:28:30Z

Starlette 0.19.0 has now been released, not sure if it's worth performing a further upgrade here, or leaving that for another time.

Kludex · 2022-03-14T04:53:58Z

As per history, Sebastián prefers to bump progressively. Also, those two releases have a lot of changes.

Net-Mist · 2022-04-21T14:13:52Z

Hello !
I would like to know more regarding the status of this PR. Is there a reason not to merge it ?

Kludex · 2022-04-26T15:45:37Z

Hello ! I would like to know more regarding the status of this PR. Is there a reason not to merge it ?

Let's wait for @tiangolo :)

github-actions · 2022-05-05T21:03:37Z

📝 Docs preview for commit e7087f5 at: https://62743b753fbbb2094bed5235--fastapi.netlify.app

github-actions · 2022-05-05T22:13:30Z

📝 Docs preview for commit 25feb07 at: https://62744bdcedfeb0165d6951ed--fastapi.netlify.app

tiangolo · 2022-05-05T22:15:34Z

Awesome @Kludex, thank you! 🙇

I added a filterwarning for pytest complaining about Cryptography so we can run tests while reaching the version that drops support for Python 3.6.

This will be available in the next release in a couple of hours, FastAPI 0.76.0 🏷️

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

Bump starlette from 0.17.1 to 0.18.0

e5c9343

Kludex commented Jan 26, 2022

View reviewed changes

Fix linter

8d10fca

Fix mypy

7331e08

Kludex commented Jan 26, 2022

View reviewed changes

Remove unused Optional import

fb2fdf5

yezz123 approved these changes Jan 26, 2022

View reviewed changes

patrick91 mentioned this pull request Jan 26, 2022

Fix compatibility with starlette 0.18.0 and above strawberry-graphql/strawberry#1594

Merged

11 tasks

Kludex mentioned this pull request Feb 11, 2022

TypeError encode/starlette#1506

Closed

2 tasks

Kludex mentioned this pull request Apr 15, 2022

Response init fails if status_code is None encode/starlette#1592

Closed

BilalAlpaslan approved these changes Apr 21, 2022

View reviewed changes

Kludex mentioned this pull request Apr 24, 2022

starlette >v0.18 requires status_code on Response init #4800

Closed

mdczaplicki approved these changes Apr 26, 2022

View reviewed changes

Merge branch 'master' into bump/starlette-0.18.0

e7087f5

🔇 Add pytest filterwarning for Jose - Cryptography - Python 3.6

25feb07

tiangolo mentioned this pull request May 5, 2022

Update Starlette to 0.18.0 to solve some issues fastapi will have on FIPs enabled systems #4477

Closed

9 tasks

tiangolo changed the title ~~Bump starlette from 0.17.1 to 0.18.0~~ ⬆ Upgrade Starlette from 0.17.1 to 0.18.0 May 5, 2022

tiangolo merged commit 33d6143 into fastapi:master May 5, 2022

JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022

⬆ Upgrade Starlette from 0.17.1 to 0.18.0 (fastapi#4483)

9c8b001

Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⬆ Upgrade Starlette from 0.17.1 to 0.18.0 #4483

⬆ Upgrade Starlette from 0.17.1 to 0.18.0 #4483

Kludex commented Jan 26, 2022 •

edited by tiangolo

Loading

codecov bot commented Jan 26, 2022 •

edited

Loading

github-actions bot commented Jan 26, 2022

Kludex Jan 26, 2022

github-actions bot commented Jan 26, 2022

Kludex Jan 26, 2022

github-actions bot commented Jan 26, 2022

yezz123 left a comment

L1ghtn1ng commented Mar 2, 2022

ShadowLNC commented Mar 14, 2022

Kludex commented Mar 14, 2022

Net-Mist commented Apr 21, 2022

Kludex commented Apr 26, 2022

github-actions bot commented May 5, 2022

github-actions bot commented May 5, 2022

tiangolo commented May 5, 2022

⬆ Upgrade Starlette from 0.17.1 to 0.18.0 #4483

⬆ Upgrade Starlette from 0.17.1 to 0.18.0 #4483

Conversation

Kludex commented Jan 26, 2022 • edited by tiangolo Loading

codecov bot commented Jan 26, 2022 • edited Loading

Codecov Report

github-actions bot commented Jan 26, 2022

Kludex Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot commented Jan 26, 2022

Kludex Jan 26, 2022

Choose a reason for hiding this comment

github-actions bot commented Jan 26, 2022

yezz123 left a comment

Choose a reason for hiding this comment

L1ghtn1ng commented Mar 2, 2022

ShadowLNC commented Mar 14, 2022

Kludex commented Mar 14, 2022

Net-Mist commented Apr 21, 2022

Kludex commented Apr 26, 2022

github-actions bot commented May 5, 2022

github-actions bot commented May 5, 2022

tiangolo commented May 5, 2022

Kludex commented Jan 26, 2022 •

edited by tiangolo

Loading

codecov bot commented Jan 26, 2022 •

edited

Loading