Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight all new lines in docs example upgrade #795

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Dec 16, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #795 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #795   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         286    288    +2     
  Lines        7466   7555   +89     
=====================================
+ Hits         7466   7555   +89
Impacted Files Coverage Δ
docs/src/openapi_callbacks/tutorial001.py 100% <0%> (ø) ⬆️
fastapi/encoders.py 100% <0%> (ø) ⬆️
fastapi/routing.py 100% <0%> (ø) ⬆️
tests/test_inherited_custom_class.py 100% <0%> (ø)
tests/test_sub_callbacks.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a44540...5e02e1b. Read the comment docs.

@tiangolo tiangolo merged commit cad6a6e into fastapi:master Jan 8, 2020
@tiangolo
Copy link
Member

tiangolo commented Jan 8, 2020

Thanks @cdeil ! 📝

My original intention was to highlight just the input body, but I see how this can look strange, as the rest of the new code is highlighted, so, let's update it ✔️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants