Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log email-validator not installed only when used #946

Merged
merged 2 commits into from
Feb 4, 2020

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Feb 4, 2020

🔇 Log email-validator not installed only when used

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #946 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #946   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         293    293           
  Lines        7692   7785   +93     
=====================================
+ Hits         7692   7785   +93
Impacted Files Coverage Δ
fastapi/openapi/models.py 100% <100%> (ø) ⬆️
...est_additional_responses_custom_validationerror.py 100% <0%> (ø) ⬆️
docs/src/app_testing/tutorial003.py 100% <0%> (ø) ⬆️
...t_query_params_str_validations/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_custom_swagger_ui_redirect.py 100% <0%> (ø) ⬆️
docs/src/first_steps/tutorial001.py 100% <0%> (ø) ⬆️
tests/test_additional_responses_router.py 100% <0%> (ø) ⬆️
docs/src/application_configuration/tutorial001.py 100% <0%> (ø) ⬆️
...test_tutorial/test_body_fields/test_tutorial001.py 100% <0%> (ø) ⬆️
tests/test_swagger_ui_init_oauth.py 100% <0%> (ø) ⬆️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55afb70...1155006. Read the comment docs.

@tiangolo tiangolo merged commit 2e0a102 into master Feb 4, 2020
@tiangolo tiangolo deleted the email-validator-warn-only-when-used branch February 4, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant