Itsme being detected on v4.7.0

[raystef66]

Describe the bug
Itsme is an ID app (Belgium) which has always been working fine under ksu.
Latest update of the app to 4.7.0 made the app detecting 'root' on the device.
The app is as UMOUNT (as ever been that way).
Even reverting the app to previous version 4.6.1 doesn't work anymore.

To Reproduce
Open Itsme app and get the 'app will not work on a rooted device...' message

Smartphone (please complete the following information):

• Poco F3
• crDroid 9.10
• A13 ksu 0.6.9

kSU log can be provided if needed.

[rushiranpise]

app link? have you tried uninstalling manager app?

[tiann]

Please make sure that it is KernelSU and not another plugin is causing the problem.

[raystef66]

@tiann
Wew that's called rapidly closing a reported issue on smt that was working before lol.
As mentioned the Itsme app wasn't detecting ksu before. After update to v4.7.0 of the itsme app detected the root function.
Also now did build a ksu-less kernel again and itsme working again so its definitely ksu related.

[tiann]

You should remove all modules and try again.

[tiann]

And also, we can know nothing from your report, even the basic information is missing.
We don't want to waste time on it.

[raystef66]

Please make sure that it is KernelSU and not another plugin is causing the problem.

ofc it ksu related - havent any plugins or smt like that
a ksu-less kernel makes the app to work again

[raystef66]

And also, we can know nothing from your report, even the basic information is missing. We don't want to waste time on it.

What basic info was missing?
Also wrote I can join ksu log report if needed so...

[TinyHai]

Please make sure that it is KernelSU and not another plugin is causing the problem.

ofc it ksu related - havent any plugins or smt like that a ksu-less kernel makes the app to work again

• flash a ksu-kernel and make sure ksu is working properly
• remove all modules
• try again

The obove steps make sure that 'Itsme' detected ksu but not the modules

[TinyHai]

And also, we can know nothing from your report, even the basic information is missing. We don't want to waste time on it.

What basic info was missing? Also wrote I can join ksu log report if needed so...

It's easy to upload a log report, so, why not?

[raystef66]

Please make sure that it is KernelSU and not another plugin is causing the problem.

ofc it ksu related - havent any plugins or smt like that a ksu-less kernel makes the app to work again

• flash a ksu-kernel and make sure ksu is working properly
• remove all modules
• try again

The obove steps make sure that 'Itsme' detected ksu but not the modules

Did that (removing all modules, 2) rebooted but didnt work.

But as a second test I did remove the adb folder in twrp, rebooted, itsme app working as expected, also giving some root works but as soon as I add 1 module it breaks Itsme app.
FYI, this wasnt the case before as I mentioned.
Maybe itsme app found a way to detect these modules rn or there's smt being changed on ksu.

[raystef66]

I redid the steps :
ksu app running and itsme working, adding module breaks it. Removing the one module, rebooting didnt fix the itsme app.
KernelSU_bugreport_2023-10-21_14_43.tar.gz

(so for me the only way to get it re-work is by removing adb folder in twrp, reboot, redo root and go on without modules...)

Log and screenshots

[tiann]

#991 (comment)

We've fixed it in v0.6.9 for kernel 5.10+, for 4.19, use this workaround.

[raystef66]

#991 (comment)

We've fixed it in v0.6.9 for kernel 5.10+, for 4.19, use this workaround.

True as I figured that out but then again it removes modules and after use of the specific app needs to re-add modules and sofort.
Would there be a way you can add the same fix as on 5.10+? (bcz detects the mountpoint of /data/adb/modules)
Can test right away on own kernel so feel free to let me know. Thx!

[tiann]

It is possible, but i won't do that personally. All my devices are 5.10+, I have no devices can test and i've no interest to do that.

[rushiranpise]

https://github.com/HuskyDG/ksu_unmount_injector/releases

Can you try with this module
It works for me, I have 4.14

[raystef66]

https://github.com/HuskyDG/ksu_unmount_injector/releases

Can you try with this module It works for me, I have 4.14

Nice! Works like a charm on 4.19 - Thnx!

[DeannWinchesterr]

https://github.com/HuskyDG/ksu_unmount_injector/releases

Can you try with this module It works for me, I have 4.14

Does the job perfectly, but most of the modules stop working 😭

[Couchy]

I had a look out of curiosity. It looks like these are the only three functions that need to be backported (for 4.19 anyway, didn't check prior)
https://elixir.bootlin.com/linux/v6.6/source/fs/namespace.c#L1869

static inline bool path_mounted(const struct path *path)
{
	return path->mnt->mnt_root == path->dentry;
}

static int can_umount(const struct path *path, int flags)
{
	struct mount *mnt = real_mount(path->mnt);

	if (!may_mount())
		return -EPERM;
	if (!path_mounted(path))
		return -EINVAL;
	if (!check_mnt(mnt))
		return -EINVAL;
	if (mnt->mnt.mnt_flags & MNT_LOCKED) /* Check optimistically */
		return -EINVAL;
	if (flags & MNT_FORCE && !capable(CAP_SYS_ADMIN))
		return -EPERM;
	return 0;
}

// caller is responsible for flags being sane
int path_umount(struct path *path, int flags)
{
	struct mount *mnt = real_mount(path->mnt);
	int ret;

	ret = can_umount(path, flags);
	if (!ret)
		ret = do_umount(mnt, flags);

	/* we mustn't call path_put() as that would clear mnt_expiry_mark */
	dput(path->dentry);
	mntput_no_expire(mnt);
	return ret;
}

[tiann]

#1060

[juleast]

#1060

Is this PR being mentioned as a possible fix?

[Bot-wxt1221]

#1060

Is this PR being mentioned as a possible fix?

@juleast Yes.