Export the flush action so that it can be invoked #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2018 11:28
|
Thanks for review! Trying to get my stack.yamls back in line... is there a typical time for merging and releasing? (happy to do it myself as well) |
|
Merged, thanks! I'll make a release later this weekend. |
|
Don't have time for this today, will do at some point during the week. |
|
Okay, thank you for your time! |
|
Hi, any possibility to do this soonish? Sorry to bug. Should really stop being a polyrepo company 🤦♂️ . |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using this library for some time, love exporting metrics to statsd (using the datadog statsd backend). However, we have never been able to use this in conjunction with a script as the statsd flusher can't be invoked manually. Hopefully this change is accepted; I have tested it using the script in question and it works great.