Report counters in an incremental fashion. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e444d8b eliminated the suppression of messages that were in some sense redundant, but as a side effect it started reporting the current counter value instead of the increment since the last report. This change causes only the increment to be reported--which is what statsd servers expect. Gauges are unaffected. This change affects only counters, but that includes the counter within each distribution.
Gabriella439
approved these changes
Jan 4, 2019
|
/cc @adinapoli-iohk |
|
@adinapoli-iohk Ping. |
|
@23Skidoo , @adinapoli-iohk , I merged master. |
|
@j6carey |
23Skidoo
approved these changes
Jun 14, 2020
|
Merged, thanks! |
|
Released on Hackage as |
|
@23Skidoo , thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit e444d8b
eliminated the suppression of messages that were
in some sense redundant, but as a side effect
it started reporting the current counter value
instead of the increment since the last report.
This change causes only the increment to be
reported--which is what statsd servers expect.
Gauges are unaffected. This change affects
only counters, but that includes the counter
within each distribution.